Remove references to SpanBoostQuery#74432
Merged
romseygeek merged 5 commits intoelastic:masterfrom Jun 23, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
romseygeek
added a commit
that referenced
this pull request
Jun 23, 2021
SpanBoostQuery will be removed in lucene 9.0. It is currently a no-op anyway, unless it appears at the top level of a span query tree, in which case it is equivalent to a standard BoostQuery. This commit removes references to SpanBoostQuery from elasticsearch SpanQueryBuilders, replacing it with BoostQuery where appropriate. It also adds a new, breaking, check to field_masking_span to ensure that its inner query does not have a boost set on it, bringing it into line with all other span queries that wrap inner spans.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SpanBoostQuery will be removed in lucene 9.0. It is currently a no-op anyway,
unless it appears at the top level of a span query tree, in which case it is
equivalent to a standard BoostQuery. This commit removes references to
SpanBoostQuery from elasticsearch SpanQueryBuilders, replacing it with
BoostQuery where appropriate.
It also adds a new, breaking, check to
field_masking_spanto ensure thatits inner query does not have a boost set on it, bringing it into line with all
other span queries that wrap inner spans.