Convert node shutdown system property feature flag to setting#74267
Convert node shutdown system property feature flag to setting#74267dakrone merged 6 commits intoelastic:masterfrom
Conversation
This converts the system property feature flag '`es.shutdown_feature_flag_enabled`' to a regular non-dynamic node setting. This setting can only be set to 'true' on a snapshot build of Elasticsearch (not a release build). Relates to elastic#70338
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
AthenaEryma
left a comment
There was a problem hiding this comment.
Left one minor suggestion. My only concern is: Are we sure that the tests will pass in release builds? Or do we need something like assumeTrue to prevent the integration tests from running? If we're good on that front, I'm good to merge this.
(admittedly depending on timing we may get rid of the feature flag before the next release is cut, but I'd rather be on the safe side)
x-pack/plugin/shutdown/src/main/java/org/elasticsearch/xpack/shutdown/ShutdownPlugin.java
Outdated
Show resolved
Hide resolved
That's a good point. I think this might cause ES not to start for integration tests also, since we set it to true in |
|
@elasticmachine update branch |
|
@gwbrown I think this should do the trick, can you take a look? |
AthenaEryma
left a comment
There was a problem hiding this comment.
LGTM once CI is happy.
My only question is: Why don't we need assumeTrue or similar in NodeShutdownIT? I'd assume that would fail unless the feature flag is enabled too.
(If it turns out we do, no need for another round of review, that's a very minimal change)
Yep, I think we need it there too, I'll add it to all those tests |
…c#74267) This converts the system property feature flag 'es.shutdown_feature_flag_enabled' to a regular non-dynamic node setting. This setting can only be set to 'true' on a snapshot build of Elasticsearch (not a release build). Relates to elastic#70338
|
@dakrone I've marked it as |
This converts the system property feature flag '
es.shutdown_feature_flag_enabled' to a regularnon-dynamic node setting. This setting can only be set to 'true' on a snapshot build of
Elasticsearch (not a release build).
Relates to #70338