[ML] Fix end offset for first_non_blank_line char_filter#73828
Merged
droberts195 merged 3 commits intoelastic:masterfrom Jun 7, 2021
Merged
Conversation
When the input gets chopped by a char_filter immediately after a token, that token must be reported as ending at the very end of the original input, otherwise analysis will have incorrect offsets when multiple field values are analyzed in the same _analyze request. The pattern_replace filter works like this. This PR changes the new first_non_blank_line filter to work in the same way. Fixes elastic/kibana#101255
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
Author
|
|
benwtrent
approved these changes
Jun 7, 2021
przemekwitek
reviewed
Jun 7, 2021
| ], | ||
| "tokenizer" : "ml_standard", | ||
| "filter" : [ | ||
| { "type" : "stop", "stopwords": [ |
There was a problem hiding this comment.
Are these stopwords needed for this particular test case? I can't see them in the "text" sentences.
Author
There was a problem hiding this comment.
Yes, true, they should not matter. I would like to keep them in the config because the aim is to test the analyzer we default to in production. So I will add a test where they do matter.
Author
|
@elasticmachine update branch |
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jun 8, 2021
When the input gets chopped by a char_filter immediately after a token, that token must be reported as ending at the very end of the original input, otherwise analysis will have incorrect offsets when multiple field values are analyzed in the same _analyze request. The pattern_replace filter works like this. This PR changes the new first_non_blank_line filter to work in the same way. Backport of elastic#73828
droberts195
added a commit
that referenced
this pull request
Jun 8, 2021
When the input gets chopped by a char_filter immediately after a token, that token must be reported as ending at the very end of the original input, otherwise analysis will have incorrect offsets when multiple field values are analyzed in the same _analyze request. The pattern_replace filter works like this. This PR changes the new first_non_blank_line filter to work in the same way. Backport of #73828
droberts195
added a commit
to droberts195/elasticsearch
that referenced
this pull request
Jun 8, 2021
Now that elastic#73882 is merged the test should pass on master. Relates elastic#73828
droberts195
added a commit
that referenced
this pull request
Jun 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the input gets chopped by a char_filter immediately after
a token, that token must be reported as ending at the very end
of the original input, otherwise analysis will have incorrect
offsets when multiple field values are analyzed in the same
_analyze request.
The pattern_replace filter works like this. This PR changes
the new first_non_blank_line filter to work in the same way.
Fixes elastic/kibana#101255