Clean up FsHealthService after MDP removal#73136
Merged
DaveCTurner merged 3 commits intoelastic:masterfrom May 17, 2021
Merged
Conversation
Following elastic#72432 we now no longer need a `Set` of unhealthy paths, we can just track the individual path directly.
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
DaveCTurner
commented
May 17, 2021
|
|
||
| private static final Logger logger = LogManager.getLogger(FsHealthService.class); | ||
| private final ThreadPool threadPool; | ||
| private volatile StatusInfo statusInfo = new StatusInfo(HEALTHY, "not started"); |
Member
Author
There was a problem hiding this comment.
Updating the status by writing to those two volatile fields was not quite correct: you could in theory observe a healthy state when transitioning from broken to unhealthy. It looks to be fixable by ordering the reads and writes carefully but the reasoning is quite fragile and it's much simpler just to do this.
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 7, 2021
This reverts commit 6a7298e. The revert was not clean. There were two adjustements necessary. First, this effectively must revert elastic#73136. Second, some tests were written after MDP removal so needed to be made multi path aware. relates elastic#78525 relates elastic#71205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following #72432 we now no longer need a
Setof unhealthy paths, wecan just track the individual path directly.