Remove multiple paths from NodeEnvironment#72599
Conversation
This commit converts the multiple paths and locks internal to NodeEnvironment into a singular data path. relates elastic#71205
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
jasontedor
left a comment
There was a problem hiding this comment.
I left a comment about the change to the log messages.
| totFSPath.add(fsPath); | ||
| } | ||
| } | ||
| if (logger.isInfoEnabled()) { |
There was a problem hiding this comment.
I don't think we should change the log messages here. Can you put it back to the debug/info differentiation, it's only that there's one path to log in each case now.
There was a problem hiding this comment.
The difference between the two cases was now only a slight difference in format, and the debug case had free space as well. This didn't seem worth a differentiation. Can you elaborate on why we should keep two slightly different log messages for the exact same info?
There was a problem hiding this comment.
Sorry I misspoke, one other difference was whether the actual path was printed.
There was a problem hiding this comment.
Mainly because changing the log messages is orthogonal to removing support for multiple data paths in NodeEnvironment.
There was a problem hiding this comment.
I also pushed d914d6a because the plural language of the message no longer makes sense.
This reverts commit b6436c5. The revert had no merge conflicts. relates elastic#78525 relates elastic#71205
This commit converts the multiple paths and locks internal to
NodeEnvironment into a singular data path.
relates #71205