Move the MDP error check into Environment#72498
Merged
rjernst merged 2 commits intoelastic:masterfrom Apr 29, 2021
Merged
Conversation
The path.data setting could previously be configured as either a yaml string, or a list. When a list, it appears internally to Settings as a List object. However, now that path.data is a String setting, it gets munged into a string representation of a list, beginning with `[`. That works if checking the original version of the setting, but there are several Settings and Environment objects creating during node initialization, and the error check would not occur until after the path was made absolute. This would make the string beginning with bracket relative to the current directory, so the check for a list string would just not work. This commit moves the check into Environment, so that the first reading of settings can error if a list is found. relates elastic#71205
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
Member
Author
|
Note that the 7.x check for list will also need adjusting, but I will do that separately since the deprecation check no longer exists in master. |
jasontedor
approved these changes
Apr 29, 2021
17 tasks
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Oct 11, 2021
This reverts commit 8602688. The revert was conflict free. relates elastic#78525 relates elastic#71205
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path.data setting could previously be configured as either a yaml
string, or a list. When a list, it appears internally to Settings as a
List object. However, now that path.data is a String setting, it gets
munged into a string representation of a list, beginning with
[. Thatworks if checking the original version of the setting, but there are
several Settings and Environment objects creating during node
initialization, and the error check would not occur until after the path
was made absolute. This would make the string beginning with bracket
relative to the current directory, so the check for a list string would
just not work.
This commit moves the check into Environment, so that the first reading
of settings can error if a list is found.
relates #71205