Avoid using external values in parent-join and percolator mappers#71834
Merged
romseygeek merged 2 commits intoelastic:masterfrom Apr 20, 2021
Merged
Avoid using external values in parent-join and percolator mappers#71834romseygeek merged 2 commits intoelastic:masterfrom
romseygeek merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
jtibshirani
approved these changes
Apr 19, 2021
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
Thanks @romseygeek for looking into this!
| throw new UnsupportedOperationException("Cannot directly call parse() on a ParentIdFieldMapper"); | ||
| } | ||
|
|
||
| public void indexValue(ParseContext context, String refId) { |
Contributor
There was a problem hiding this comment.
Small comment, maybe createIdField would be more precise, since we aren't actually indexing values here. A similar thought applies to BinaryFieldMapper#indexValue.
Contributor
Author
There was a problem hiding this comment.
We've been calling the equivalent methods on other field mappers (created for index-time scripts) indexValue - maybe we should change those as well?
Contributor
There was a problem hiding this comment.
I would be in favor of that!
Contributor
Author
|
@elasticmachine update branch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We would like to remove the use of 'external values' in document parsing.
This commit simplifies two of the four places it is currently used, by adding
direct
indexValuemethods to BinaryFieldMapper and ParentIdFieldMapper.Relates to #56063