Avoid forking in AbstractSearchAsyncAction#71580
Merged
dnhatn merged 7 commits intoelastic:masterfrom Apr 15, 2021
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
jimczi
approved these changes
Apr 14, 2021
Contributor
jimczi
left a comment
There was a problem hiding this comment.
LGTM, should also remove the fork in
executeNext will fork if needed ?
Member
Author
|
@jimczi I think it's not entirely safe to remove I think we should fork only after several executions instead of a single execution (the current behavior). I will look into it in a follow-up. |
Contributor
|
Right, I read too quickly and thought that executeNext would handle the retry on another replica. Let's leave it for a follow up. Thanks |
Member
Author
|
Thanks Jim! |
dnhatn
added a commit
that referenced
this pull request
Apr 15, 2021
We don't need to fork when handling unassigned shard failures in AbstractSearchAsyncAction as we never call it recursively. Relates #70792
dnhatn
added a commit
that referenced
this pull request
Apr 15, 2021
We don't need to fork when handling unassigned shard failures in AbstractSearchAsyncAction as we never call it recursively. Relates #70792
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to fork when handling unassigned shard failures in AbstractSearchAsyncAction as we never call it recursively.
Relates #70792