Templates match indices with date math expressions#71433
Merged
danhermann merged 3 commits intoelastic:masterfrom Apr 8, 2021
Merged
Templates match indices with date math expressions#71433danhermann merged 3 commits intoelastic:masterfrom
danhermann merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-core-features (Team:Core/Features) |
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
Thanks, @dakrone! |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Apr 12, 2021
Contributor
|
@danhermann Looks like we're good to remove |
danhermann
added a commit
to danhermann/elasticsearch
that referenced
this pull request
Apr 20, 2021
danhermann
added a commit
that referenced
this pull request
Apr 20, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The root cause of the bug identified in #69727 (reported independently by several users) is that the
findV?Templatesmethods inMetadataIndexTemplateServicedo not resolve index names with date math expressions before attempting to match them. The reproduction scenario in #69727 demonstrates one flavor of this problem. Before 7.9, an ingest pipeline with a date_index_name processor would (accidentally) work around that problem, but the simple statement below would fail to execute the final pipeline in any ES version (assuming a template that defines a final pipeline for an index pattern oftest-*):A change to the way ingest pipelines work in 7.9 caused the date_index_name scenario to fail as well. This change resolves both problems.
Fixes #69727.