Skip to content

Auto convert shared_cache SBIs to only use frozen tier#71014

Merged
dakrone merged 6 commits intoelastic:masterfrom
dakrone:auto-convert-scss-settings
Mar 31, 2021
Merged

Auto convert shared_cache SBIs to only use frozen tier#71014
dakrone merged 6 commits intoelastic:masterfrom
dakrone:auto-convert-scss-settings

Conversation

@dakrone
Copy link
Copy Markdown
Member

@dakrone dakrone commented Mar 29, 2021

This commit converts the index metadata of searchable snapshot indices using the shared_cache
storage type to:

  • Remove all the index.routing.allocation.(include|exclude|require)._tier settings
  • Sets index.routing.allocation.include._tier_preference to data_frozen automatically when the index metadata is read

This is in preperation to enforcing that the _tier_preference setting is always set to
data_frozen for shared cache SBIs.

Relates to #70846, #71013, #70786, #70141

This commit converts the index metadata of searchable snapshot indices using the `shared_cache`
storage type to:

- Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings
- Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read

This is in preperation to enforcing that the `_tier_preference` setting is always set to
`data_frozen` for shared cache SBIs.

Relates to elastic#70846, elastic#71013, elastic#70786, elastic#70141
@dakrone dakrone added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs v8.0.0 v7.13.0 labels Mar 29, 2021
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Mar 29, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

Copy link
Copy Markdown
Contributor

@henningandersen henningandersen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dakrone dakrone merged commit cf61996 into elastic:master Mar 31, 2021
@dakrone dakrone deleted the auto-convert-scss-settings branch March 31, 2021 16:17
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Mar 31, 2021
This commit converts the index metadata of searchable snapshot indices using the `shared_cache`
storage type to:

- Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings
- Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read

This is in preperation to enforcing that the `_tier_preference` setting is always set to
`data_frozen` for shared cache SBIs.

Relates to elastic#70846, elastic#71013, elastic#70786, elastic#70141
dakrone added a commit that referenced this pull request Mar 31, 2021
…#71129)

This commit converts the index metadata of searchable snapshot indices using the `shared_cache`
storage type to:

- Remove all the `index.routing.allocation.(include|exclude|require)._tier` settings
- Sets `index.routing.allocation.include._tier_preference` to `data_frozen` automatically when the index metadata is read

This is in preperation to enforcing that the `_tier_preference` setting is always set to
`data_frozen` for shared cache SBIs.

Relates to #70846, #71013, #70786, #70141
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Mar 31, 2021
We already set `data_frozen` for partial searchable snapshots when they are mounted (elastic#70786), and
automatically convert values other than the frozen role automatically for these snapshots when the
metadata is loaded (elastic#71014). This commit makes the `_tier_preference` setting validate that the
setting is *only* `data_frozen` when set on a partial searchable snapshot index.
dakrone added a commit that referenced this pull request Apr 6, 2021
…71155)

We already set `data_frozen` for partial searchable snapshots when they are mounted (#70786), and
automatically convert values other than the frozen role automatically for these snapshots when the
metadata is loaded (#71014). This commit makes the `_tier_preference` setting validate that the
setting is *only* `data_frozen` when set on a partial searchable snapshot index.
dakrone added a commit to dakrone/elasticsearch that referenced this pull request Apr 6, 2021
…lastic#71155)

We already set `data_frozen` for partial searchable snapshots when they are mounted (elastic#70786), and
automatically convert values other than the frozen role automatically for these snapshots when the
metadata is loaded (elastic#71014). This commit makes the `_tier_preference` setting validate that the
setting is *only* `data_frozen` when set on a partial searchable snapshot index.
dakrone added a commit that referenced this pull request Apr 13, 2021
…rence (#71155) (#71342)

* Enforce data_frozen for partial searchable snapshot _tier_preference (#71155)

We already set `data_frozen` for partial searchable snapshots when they are mounted (#70786), and
automatically convert values other than the frozen role automatically for these snapshots when the
metadata is loaded (#71014). This commit makes the `_tier_preference` setting validate that the
setting is *only* `data_frozen` when set on a partial searchable snapshot index.

* Handle mixed version clusters with pre-7.13.0 frozen SBIs

* Fix checkstyyyyyyyyle

* Pass index version in settings for test

* Unconditionally return only data_frozen for setting

Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >refactoring Team:Distributed Meta label for distributed team. v7.13.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants