Remove test skip after backport#70890
Merged
nik9000 merged 1 commit intoelastic:masterfrom Mar 26, 2021
Merged
Conversation
This restores SQL's test for fetching `half_floats` after we backported the precision change in that fetch (elastic#70653)
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Mar 26, 2021
When restoring SQL's test for fetching `half_floats` in master we bumped into some type conversion issues. This backports those type changes so 7.x and master line up more closely.
nik9000
added a commit
that referenced
this pull request
Mar 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This restores SQL's test for fetching
half_floatsafter we backportedthe precision change in that fetch (#70653).