Add REST scaffolding for node shutdown API #70697
Merged
dakrone merged 6 commits intoelastic:masterfrom Mar 23, 2021
Merged
Conversation
This commit adds the rest endpoints for the node shutdown API. These APIs are behind the `es.shutdown_feature_flag_enabled` feature flag for now, as development is ongoing. Currently these APIs do not do anything, returning immediately. We plan to implement them for real in subsequent work. Relates to elastic#70338
Collaborator
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
22 tasks
rjernst
reviewed
Mar 23, 2021
|
|
||
| @Override | ||
| public List<Route> routes() { | ||
| return List.of(new Route(RestRequest.Method.GET, "/_node/{name}/shutdown"), new Route(RestRequest.Method.GET, "/_node/shutdown")); |
Member
There was a problem hiding this comment.
nit: doesn't /_node/{name}/shutdown conflict with /_node/shutdown since you cannot have a node named shutdown?
Member
Author
There was a problem hiding this comment.
No, we do this all over the place already, for example, in RestNodesStatsAction we have:
new Route(GET, "/_nodes/stats"),
new Route(GET, "/_nodes/{nodeId}/stats"),
Member
Author
|
@elasticmachine update branch |
AthenaEryma
approved these changes
Mar 23, 2021
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
LGTM as a skeleton for this API. Looking forward to hooking it up!
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Mar 23, 2021
This commit adds the rest endpoints for the node shutdown API. These APIs are behind the `es.shutdown_feature_flag_enabled` feature flag for now, as development is ongoing. Currently these APIs do not do anything, returning immediately. We plan to implement them for real in subsequent work. Relates to elastic#70338
dakrone
added a commit
that referenced
this pull request
Mar 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the rest endpoints for the node shutdown API. These APIs are behind the
es.shutdown_feature_flag_enabledfeature flag for now, as development is ongoing.Currently these APIs do not do anything, returning immediately. We plan to implement them for real
in subsequent work.
Relates to #70338