[Transform] fix itermittent problem in TransformIndexerTests/TransformIndexerFailureHandlingTests#70326
Merged
hendrikmuhs merged 1 commit intoelastic:masterfrom Mar 15, 2021
Merged
Conversation
…n the process of shutting down, when the test thread triggers it again. relates elastic#69551 fixes elastic#70297
Collaborator
|
Pinging @elastic/ml-core (Team:ML) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix a race condition in the test: the indexer thread might still be in the
process of shutting down, when the test thread triggers it again.
relates #69551
fixes #70297
Note: The test suite has been renamed in
master/7.x/7.12toTransformIndexerFailureHandlingTests, in the7.11branch the testsuite is calledTransformIndexerTests, as in the issue (-> the 7.11 backport requires careful handling).