Throw IAE for runtime mappings in _field_caps for older nodes#69722
Merged
cbuescher merged 2 commits intoelastic:masterfrom Mar 1, 2021
Merged
Throw IAE for runtime mappings in _field_caps for older nodes#69722cbuescher merged 2 commits intoelastic:masterfrom
cbuescher merged 2 commits intoelastic:masterfrom
Conversation
Typically we silently ignore nodes below a certain version that don't support a specific feature when serializing requests between nodes. With runtime fields we chose to throw errors instead when one of the nodes a search request is sent to has a version that does not support the runtime fields feature. This change adds the same behaviour for support of the "runtime_mappings" section introduced in elastic#68904 in the "_field_caps" API. Relates to elastic#68904
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
cbuescher
pushed a commit
that referenced
this pull request
Mar 1, 2021
Typically we silently ignore nodes below a certain version that don't support a specific feature when serializing requests between nodes. With runtime fields we chose to throw errors instead when one of the nodes a search request is sent to has a version that does not support the runtime fields feature. This change adds the same behaviour for support of the "runtime_mappings" section introduced in #68904 in the "_field_caps" API. Relates to #68904
cbuescher
pushed a commit
that referenced
this pull request
Mar 2, 2021
Typically we silently ignore nodes below a certain version that don't support a specific feature when serializing requests between nodes. With runtime fields we chose to throw errors instead when one of the nodes a search request is sent to has a version that does not support the runtime fields feature. This change adds the same behaviour for support of the "runtime_mappings" section introduced in #68904 in the "_field_caps" API. Relates to #68904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Typically we silently ignore nodes below a certain version that don't support a
specific feature when serializing requests between nodes. With runtime fields we
chose to throw errors instead when one of the nodes a search request is sent to
has a version that does not support the runtime fields feature. This change adds
the same behaviour for support of the "runtime_mappings" section introduced in #68904
in the "_field_caps" API.
Relates to #68904