Remove some obsolete exceptions#69675
Merged
DaveCTurner merged 2 commits intoelastic:masterfrom Mar 1, 2021
Merged
Conversation
- `NodeShouldNotConnectException` has not been instantiated since 5.0 - `GatewayException` has not been instantiated since 5.0 - `SnapshotFailedEngineException` has not been instantated since 6.2.0 (elastic#28038) and was never thrown across clusters This commit removes these obsolete exceptions.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
| if (logger.isDebugEnabled() && (t instanceof NodeShouldNotConnectException) == false) { | ||
| logger.debug(new ParameterizedMessage("failed to execute [{}] on node [{}]", actionName, nodeId), t); | ||
| } | ||
| logger.debug(new ParameterizedMessage("failed to execute [{}] on node [{}]", actionName, nodeId), t); |
Contributor
There was a problem hiding this comment.
NIT: maybe keep the logger.isDebugEnabled() here and in the other 2 spots changed so that we don't have to create the message object needlessly? (doesn't look too performance critical ever :) so pretty optional)
Member
Author
There was a problem hiding this comment.
I'd rather not, we're on a (hopefully rare) failure path here already, and making this one extra object should be super-cheap whereas making me read an extra conditional every time I look at this is not :)
DaveCTurner
added a commit
that referenced
this pull request
Mar 1, 2021
- `NodeShouldNotConnectException` has not been instantiated since 5.0 - `GatewayException` has not been instantiated since 5.0 - `SnapshotFailedEngineException` has not been instantated since 6.2.0 (#28038) and was never thrown across clusters This commit removes these obsolete exceptions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodeShouldNotConnectExceptionhas not been instantiated since 5.0GatewayExceptionhas not been instantiated since 5.0SnapshotFailedEngineExceptionhas not been instantated since 6.2.0(Primary send safe commit in file-based recovery #28038) and was never thrown across clusters
This commit removes these obsolete exceptions.