Merged
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
One of the tests that I added in elastic#68871 worked about 99.7% of the time but on some seeds failed to generate the right buckets because on those seeds we would collect each segment with its own aggregator and get bad counts. This "bad counts" problem is known in the terms aggregator - its the price we pay for distributed work. But we can work around it either by forcing all the docs into a single segment or by collecting all of the buckets on the shard. We want to test the code path where don't collect all buckets on the shard so we opt for the former. Closes elastic#69413
nik9000
added a commit
that referenced
this pull request
Feb 23, 2021
One of the tests that I added in #68871 worked about 99.7% of the time but on some seeds failed to generate the right buckets because on those seeds we would collect each segment with its own aggregator and get bad counts. This "bad counts" problem is known in the terms aggregator - its the price we pay for distributed work. But we can work around it either by forcing all the docs into a single segment or by collecting all of the buckets on the shard. We want to test the code path where don't collect all buckets on the shard so we opt for the former. Closes #69413
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One of the tests that I added in #68871 worked about 99.7% of the time
but on some seeds failed to generate the right buckets because on those
seeds we would collect each segment with its own aggregator and get bad
counts. This "bad counts" problem is known in the terms aggregator - its
the price we pay for distributed work. But we can work around it either
by forcing all the docs into a single segment or by collecting all of
the buckets on the shard. We want to test the code path where don't
collect all buckets on the shard so we opt for the former.
Closes #69413