Test: assert adjacency matrix cache#69440
Merged
nik9000 merged 3 commits intoelastic:masterfrom Apr 13, 2021
Merged
Conversation
Adds an assertion that the adjacency matrix aggregation can hit the request cache even when the request contains a lookup style `terms` filter.
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
69 tasks
imotov
approved these changes
Apr 12, 2021
Contributor
imotov
left a comment
There was a problem hiding this comment.
Added a minor suggestion. Otherwise LGTM.
| - do: | ||
| indices.stats: { index: test, metric: request_cache} | ||
| - match: { _shards.total: 1 } | ||
| - match: { _all.total.request_cache.hit_count: 1 } |
Contributor
There was a problem hiding this comment.
That game me a bit of a pause. Took me a bit to realize that you are asking for one index only in stats. I think it would have been clearer if it was indices.test.total.request_cache.hit_coun instead of _all.total.....
Member
Author
|
Thanks for reviewing @imotov ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Apr 13, 2021
Adds an assertion that the adjacency matrix aggregation can hit the request cache even when the request contains a lookup style `terms` filter.
Member
Author
|
I believe there is an error in this one around caching. I've added the infrastructure to fix that error in #69439. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an assertion that the adjacency matrix aggregation can hit the
request cache even when the request contains a lookup style
termsfilter.