Skip to content

Add RateLimitingFiltering to plaintext deprecation logs#69190

Merged
pgomulka merged 3 commits intoelastic:7.xfrom
pgomulka:fix_filtering_old_style_deprecation_logs
Feb 23, 2021
Merged

Add RateLimitingFiltering to plaintext deprecation logs#69190
pgomulka merged 3 commits intoelastic:7.xfrom
pgomulka:fix_filtering_old_style_deprecation_logs

Conversation

@pgomulka
Copy link
Copy Markdown
Contributor

@pgomulka pgomulka commented Feb 18, 2021

The #61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs

closes #69188

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against master? Unless there is a good reason otherwise, we prefer pull requests against master and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@pgomulka
Add RateLimitingFiltering to plaintext deprecation logs
aedf6cc 
The elastic#61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs

closes elastic#69188
@pgomulka pgomulka added :Core/Infra/Logging Log management and logging utilities v7.13.0 labels Feb 18, 2021
@pgomulka pgomulka requested a review from pugnascotia February 18, 2021 14:51
@pgomulka pgomulka self-assigned this Feb 18, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Feb 18, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Feb 18, 2021

Pinging @elastic/es-core-infra (Team:Core/Infra)

@pgomulka
Copy link
Copy Markdown
Contributor Author

pgomulka commented Feb 18, 2021

btw @pugnascotia I feel we should try to figure out how do we test against our real log4j2 properties file. JsonLoggerTests are at the moment using a similar file which can get stale.
We would need to figure out a way to access the real config..

pugnascotia
pugnascotia approved these changes Feb 19, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@pugnascotia pugnascotia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing this!

@pgomulka pgomulka merged commit 5e70eae into elastic:7.x Feb 23, 2021
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Feb 23, 2021
@pgomulka
Add RateLimitingFiltering to plaintext deprecation logs (elastic#69190)
c008934 
The elastic#61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs

closes elastic#69188
@pgomulka pgomulka mentioned this pull request Feb 23, 2021
Merged
pgomulka added a commit to pgomulka/elasticsearch that referenced this pull request Feb 23, 2021
@pgomulka
Add RateLimitingFiltering to plaintext deprecation logs (elastic#69190)
4d9dbb1 
The elastic#61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs

closes elastic#69188
This was referenced Feb 23, 2021
Merged
Closed
pgomulka added a commit that referenced this pull request Feb 23, 2021
@pgomulka
Add RateLimitingFiltering to plaintext deprecation logs backport(#69190…
a2022af 
…) #69427

The #61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs

closes #69188
backport(#69190)
pgomulka added a commit that referenced this pull request Feb 23, 2021
@pgomulka
Add RateLimitingFiltering to plaintext deprecation logs backport(#69190…
2f3e826 
…) #69426

The #61474 changed the way we throttle deprecation logs, but missed a
filter to plaintext deprecation logs

closes #69188
backport(#69190)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pugnascotia pugnascotia pugnascotia approved these changes

Assignees

No one assigned

Labels

>bug :Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v7.13.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@pgomulka @elasticmachine @pugnascotia