[7.x] Revert "Remove aggregation's postCollect phase#68942
Merged
imotov merged 4 commits intoelastic:7.xfrom Feb 12, 2021
Merged
[7.x] Revert "Remove aggregation's postCollect phase#68942imotov merged 4 commits intoelastic:7.xfrom
imotov merged 4 commits intoelastic:7.xfrom
Conversation
This partially reverts elastic#64016 and and adds elastic#67839 and adds additional tests that would have caught issues with the changes in elastic#64016. It's mostly Nik's code, I am just cleaning things up a bit. Co-authored-by: Nik Everett <nik9000@gmail.com>
Fat-fingered the skip statement in this one. Relates to elastic#66876
Collaborator
|
Pinging @elastic/es-analytics-geo (Team:Analytics) |
imotov
added a commit
to imotov/elasticsearch
that referenced
this pull request
Feb 16, 2021
This partially reverts elastic#64016 and and adds elastic#67839 and adds additional tests that would have caught issues with the changes in elastic#64016. It's mostly Nik's code, I am just cleaning things up a bit. Co-authored-by: Nik Everett nik9000@gmail.com
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert "Remove aggregation's postCollect phase (#68615)
This partially reverts #64016 and and adds #67839 and adds
additional tests that would have caught issues with the changes
in #64016. It's mostly Nik's code, I am just cleaning things up
a bit.
Co-authored-by: Nik Everett nik9000@gmail.com