Fix Threading in Snapshot Restore#68390
Merged
original-brownbear merged 2 commits intoelastic:masterfrom Feb 3, 2021
original-brownbear:fix-restore-loading-of-global-metadata
Merged
Fix Threading in Snapshot Restore#68390original-brownbear merged 2 commits intoelastic:masterfrom original-brownbear:fix-restore-loading-of-global-metadata
original-brownbear merged 2 commits intoelastic:masterfrom
original-brownbear:fix-restore-loading-of-global-metadata
Conversation
Same as #68023 but even less likely (couldn't really find a quick way to write a test for it for that reason). Fix is the same, fork off to the generic pool for listener handling. Also, this allows removing the forking in the transport action since we don't do any long runnning work on the calling thread any longer in the restore method.
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
fcofdez
reviewed
Feb 2, 2021
server/src/main/java/org/elasticsearch/snapshots/RestoreService.java
Outdated
Show resolved
Hide resolved
Contributor
|
@elasticmachine update branch |
Collaborator
|
merge conflict between base and head |
…g-of-global-metadata
Contributor
Author
|
Jenkins run elasticsearch-ci/2 |
Contributor
Author
|
Thanks Francisco! |
original-brownbear
added a commit
that referenced
this pull request
Feb 3, 2021
Same as #68023 but even less likely (couldn't really find a quick way to write a test for it for that reason). Fix is the same, fork off to the generic pool for listener handling. Also, this allows removing the forking in the transport action since we don't do any long runnning work on the calling thread any longer in the restore method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Same as #68023 but even less likely (couldn't really find a quick way
to write a test for it for that reason).
Fix is the same, fork off to the generic pool for listener handling.
Also, this allows removing the forking in the transport action since we don't do any long
running work on the calling thread any longer in the restore method.
non issue since this didn't leak into any released version