Skip to content

Update template warning for FIPS in Netty test#67067

Merged
tvernum merged 3 commits intoelastic:masterfrom
tvernum:fix/fips/66820-template-warning
Jan 7, 2021
Merged

Update template warning for FIPS in Netty test#67067
tvernum merged 3 commits intoelastic:masterfrom
tvernum:fix/fips/66820-template-warning

Conversation

@tvernum
Copy link
Copy Markdown
Contributor

@tvernum tvernum commented Jan 6, 2021

This changes the expected error message (on FIPS) so that the
order of the templates (and their associated patterns) matches
the (newly updated) order generated by the server.

Relates: #67066
Resolves: #66820

This changes the expected error message (on FIPS) so that the
order of the templates (and their associated patterns) matches
the (newly updated) order generated by the server.

Relates: elastic#67066
Resolves: elastic#66820
@tvernum tvernum added >test Issues or PRs that are addressing/adding tests v8.0.0 v7.12.0 :Security/FIPS Running ES in FIPS 140-2 mode labels Jan 6, 2021
@tvernum tvernum requested a review from ywangd January 6, 2021 02:51
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Jan 6, 2021
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-security (Team:Security)

@tvernum
Copy link
Copy Markdown
Contributor Author

tvernum commented Jan 6, 2021

This PR will only resolve the problem once #67066 is merged.

Copy link
Copy Markdown
Member

@ywangd ywangd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending #67066

@tvernum
Copy link
Copy Markdown
Contributor Author

tvernum commented Jan 7, 2021

@elasticmachine update branch

@tvernum tvernum merged commit 248b6a8 into elastic:master Jan 7, 2021
tvernum added a commit to tvernum/elasticsearch that referenced this pull request Jan 11, 2021
This changes the expected error message (on FIPS) so that the
order of the templates (and their associated patterns) matches
the (newly updated) order generated by the server.

Relates: elastic#67066
Resolves: elastic#66820

Backport of: elastic#67067
tvernum added a commit that referenced this pull request Jan 12, 2021
This changes the expected error message (on FIPS) so that the
order of the templates (and their associated patterns) matches
the (newly updated) order generated by the server.

Backport of: #67067
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Security/FIPS Running ES in FIPS 140-2 mode Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v7.12.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Netty4HeadBodyIsEmptyIT.testTemplateExists fails in fips mode

4 participants