Don't require DocumentMapper as an argument when parsing a document#66780
Merged
javanna merged 5 commits intoelastic:masterfrom Jan 4, 2021
Merged
Conversation
Currently, an incoming document is parsed through `DocumentMapper#parse`, which in turns calls `DocumentParser#parseDocument` providing `this` among other arguments. As part of the effort to reduce usages of `DocumentMapper` when possible, as it represents the mutable side of mappings (through mappings updates) and involves complexity, we can carry around only the needed components. This does add some required arguments to `DocumentParser#parseDocument` , though it makes dependencies clearer. This change does not affect end consumers as they all go through DocumentMapper anyways, but by not needed to provide DocumentMapper to parseDocument, we may be able to unblock further improvements down the line. Relates to elastic#66295
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
Contributor
Author
|
run elasticsearch-ci/2 |
Contributor
Author
|
@nik9000 can I get a review? |
romseygeek
approved these changes
Jan 4, 2021
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM, one nit regarding import re-ordering.
|
|
||
| package org.elasticsearch.percolator; | ||
|
|
||
| import static org.elasticsearch.common.network.InetAddresses.forString; |
Contributor
There was a problem hiding this comment.
Can you revert the import changes? They'll get changed back next time somebody with different settings edits the file and it just adds noise.
Contributor
Author
There was a problem hiding this comment.
I am trying to figure out what is going on. I think I configured the formatter based on our formatting file, and since then imports order get automatically adjusted. Not loving it either in projects where we don't yet auto-format files.
nik9000
approved these changes
Jan 4, 2021
Member
nik9000
left a comment
There was a problem hiding this comment.
Lgtm. Sorry for delay in review!
javanna
added a commit
to javanna/elasticsearch
that referenced
this pull request
Jan 4, 2021
…lastic#66780) Currently, an incoming document is parsed through `DocumentMapper#parse`, which in turns calls `DocumentParser#parseDocument` providing `this` among other arguments. As part of the effort to reduce usages of `DocumentMapper` when possible, as it represents the mutable side of mappings (through mappings updates) and involves complexity, we can carry around only the needed components. This does add some required arguments to `DocumentParser#parseDocument` , though it makes dependencies clearer. This change does not affect end consumers as they all go through DocumentMapper anyways, but by not needed to provide DocumentMapper to parseDocument, we may be able to unblock further improvements down the line. Relates to elastic#66295
javanna
added a commit
that referenced
this pull request
Jan 5, 2021
…66780) Currently, an incoming document is parsed through `DocumentMapper#parse`, which in turns calls `DocumentParser#parseDocument` providing `this` among other arguments. As part of the effort to reduce usages of `DocumentMapper` when possible, as it represents the mutable side of mappings (through mappings updates) and involves complexity, we can carry around only the needed components. This does add some required arguments to `DocumentParser#parseDocument` , though it makes dependencies clearer. This change does not affect end consumers as they all go through DocumentMapper anyways, but by not needed to provide DocumentMapper to parseDocument, we may be able to unblock further improvements down the line. Relates to #66295
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, an incoming document is parsed through
DocumentMapper#parse, which in turns callsDocumentParser#parseDocumentprovidingthisamong other arguments. As part of the effort to reduce usages ofDocumentMapperwhen possible, as it represents the mutable side of mappings (through mappings updates) and involves complexity, we can carry around only the needed components. This does add some required arguments toDocumentParser#parseDocument, though it makes dependencies clearer. This change does not affect end consumers as they all go through DocumentMapper anyways, but by not needed to provide DocumentMapper to parseDocument, we may be able to unblock further improvements down the line.Relates to #66295