Skip to content

[TEST] Ensure InvalidateApiKeyRequest has at least one key in test#66696

Merged
dimitris-athanasiou merged 1 commit intoelastic:masterfrom
dimitris-athanasiou:ensure-invalidate-api-key-request-has-at-least-one-key-in-test
Dec 21, 2020
Merged

[TEST] Ensure InvalidateApiKeyRequest has at least one key in test#66696
dimitris-athanasiou merged 1 commit intoelastic:masterfrom
dimitris-athanasiou:ensure-invalidate-api-key-request-has-at-least-one-key-in-test

Conversation

@dimitris-athanasiou
Copy link
Copy Markdown
Contributor

@dimitris-athanasiou dimitris-athanasiou commented Dec 21, 2020

Fixes potential failure in InvalidateApiKeyRequestTests where
a request is constructed with empty keys.

Relates #66317

@dimitris-athanasiou
[TEST] Ensure InvalidateApiKeyRequest has at least one key in test
24447e9 
Fixes potential failure in `InvalidateApiKeyRequestTests` where
a request is constructed with empty keys.
@dimitris-athanasiou dimitris-athanasiou added >test Issues or PRs that are addressing/adding tests :Security/Security Security issues without another label v8.0.0 v7.12.0 labels Dec 21, 2020
@elasticmachine elasticmachine added the Team:Security Meta label for security team label Dec 21, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Dec 21, 2020

Pinging @elastic/es-security (Team:Security)

@dimitris-athanasiou dimitris-athanasiou requested review from albertzaharovits and jkakavas and removed request for jkakavas and ywangd December 21, 2020 14:52
@dimitris-athanasiou dimitris-athanasiou merged commit 35aa4f7 into elastic:master Dec 21, 2020
@dimitris-athanasiou dimitris-athanasiou deleted the ensure-invalidate-api-key-request-has-at-least-one-key-in-test branch December 21, 2020 15:40
@albertzaharovits
Copy link
Copy Markdown
Contributor

albertzaharovits commented Dec 21, 2020

Thank you Dimitris!

@dimitris-athanasiou dimitris-athanasiou mentioned this pull request Dec 21, 2020
Merged
ywangd added a commit that referenced this pull request Dec 22, 2020
@ywangd
Deprecate the id field for the InvalidateApiKey API (#66317) (#66670)
f0715f9 
This PR deprecates the usage of the id field in the payload for the
InvalidateApiKey API. The ids field introduced in #63224 is now the recommended
way for performing (bulk) API key invalidation.

This PR also includes the test fix from #66696
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albertzaharovits albertzaharovits albertzaharovits approved these changes

Assignees

No one assigned

Labels

:Security/Security Security issues without another label Team:Security Meta label for security team >test Issues or PRs that are addressing/adding tests v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dimitris-athanasiou @elasticmachine @albertzaharovits @jakelandis