Skip to content

[DOCS] Network community ID processor for ingest pipelines#66592

Merged
danhermann merged 4 commits intoelastic:masterfrom
danhermann:docs_for_66534
Jan 20, 2021
Merged

[DOCS] Network community ID processor for ingest pipelines#66592
danhermann merged 4 commits intoelastic:masterfrom
danhermann:docs_for_66534

Conversation

@danhermann
Copy link
Copy Markdown
Contributor

Depends on #66534.

@danhermann danhermann added >docs General docs changes :Distributed/Ingest Node Execution or management of Ingest Pipelines v8.0.0 v7.12.0 labels Dec 18, 2020
@elasticmachine elasticmachine added Team:Docs Meta label for docs team Team:Data Management (obsolete) DO NOT USE. This team no longer exists. labels Dec 18, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-core-features (Team:Core/Features)

<titleabbrev>Community ID</titleabbrev>
++++

Computes the Community ID for flow data as defined in the
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll defer to the ES Docs team reviewer on this one as I have no strong inclination either way.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should copy the paragraphs verbatim. That text is pretty Beats-centric. However, we can include a brief sentence about how a community ID is used and the ECS defaults. I've included a related suggestion below.

| `iana_number` | no | `network.iana_number` | Field containing the IANA number.
| `icmp_type` | no | `icmp.type` | Field containing the ICMP type.
| `icmp_code` | no | `icmp.code` | Field containing the ICMP code.
| `transport` | no | `network.transport` | Field containing the transport protocol.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention that this field is only used when the iana_number field does not exist?

danhermann and others added 2 commits December 18, 2020 10:34
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I left a few suggestions but nothing I would consider blocking (except a minor typo).
Thanks, @danhermann!

include::common-options.asciidoc[]
|======

Here is an example definition of the URI parts processor:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Here is an example definition of the URI parts processor:
Here is an example definition of the community ID processor:

Comment on lines +9 to +10
Computes the Community ID for flow data as defined in the
https://github.com/corelight/community-id-spec[Community ID Specification].
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lowercases community ID. Also adds a few additional sentences as noted above.

Suggested change
Computes the Community ID for flow data as defined in the
https://github.com/corelight/community-id-spec[Community ID Specification].
Computes the community ID for network flow data as defined in the
https://github.com/corelight/community-id-spec[Community ID Specification]. You
can use a community ID to correlate network events related to a single flow.
The community ID processor reads network flow data from related
{ecs-ref}[Elastic Common Schema (ECS)] fields by default. If you use the ECS, no
configuration is required.

<titleabbrev>Community ID</titleabbrev>
++++

Computes the Community ID for flow data as defined in the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should copy the paragraphs verbatim. That text is pretty Beats-centric. However, we can include a brief sentence about how a community ID is used and the ECS defaults. I've included a related suggestion below.

Used only when the `iana_number` field is not present.
| `target_field` | no | `network.community_id` | Output field for the community ID.
| `seed` | no | `0` | Seed for the community ID hash. Must be between
0 and 65535. This can be use to prevent hash collisions between network domains
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig Dec 18, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not clear if this range is inclusive or exclusive, though you can guess from the default. I'd just add a parenthetical afterward, e.g. (inclusive).

Suggested change
0 and 65535. This can be use to prevent hash collisions between network domains
`0` and `65535` (inclusive). The seed prevents hash collisions between network domains,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Distributed/Ingest Node Execution or management of Ingest Pipelines >docs General docs changes Team:Data Management (obsolete) DO NOT USE. This team no longer exists. Team:Docs Meta label for docs team v7.12.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants