Remove unsed fields in RestAnalyzeAction#66215
Conversation
|
Pinging @elastic/es-search (Team:Search) |
|
@elasticmachine test this please |
cbuescher
left a comment
There was a problem hiding this comment.
Hi @chengyang14,
thanks a lot for opening this PR and your contribution to Elasticsearch. I looked at the changes and was suprised we don't use the ParseFields here. I saw we now do the parsing of the "_anaylze" request in the ObjectParser defined in class AnalyzeAction. Instead of deleting six of the constants here and leaving the three that are used in CategorizationAnalyzerConfig, I think I would be good to move all constants to AnalyzeAction and use them in the parser definition there and also point to them from CategorizationAnalyzerConfig. Would you mind making those changes?
|
Hi @cbuescher |
|
@elasticmachine test this please |
cbuescher
left a comment
There was a problem hiding this comment.
Thanks for the changes, LGTM.
I'll be running our CI test suit before merging.
Moves ParseFields from `RestAnalyzeAction` to `AnalyzeAction` where they are actually used for parsing the request body.
|
@chengyang14 thanks for this change, I merged it to master and the 7.x branch. |
* elastic/master: (33 commits) Add searchable snapshot cache folder to NodeEnvironment (elastic#66297) [DOCS] Add dynamic runtime fields to docs (elastic#66194) Add HDFS searchable snapshot integration (elastic#66185) Support canceling cross-clusters search requests (elastic#66206) Mute testCacheSurviveRestart (elastic#66289) Fix cat tasks api params in spec and handler (elastic#66272) Snapshot of a searchable snapshot should be empty (elastic#66162) [ML] DFA _explain API should not fail when none field is included (elastic#66281) Add action to decommission legacy monitoring cluster alerts (elastic#64373) move rollup_index param out of RollupActionConfig (elastic#66139) Improve FieldFetcher retrieval of fields (elastic#66160) Remove unsed fields in `RestAnalyzeAction` (elastic#66215) Simplify searchable snapshot CacheKey (elastic#66263) Autoscaling remove feature flags (elastic#65973) Improve searchable snapshot mount time (elastic#66198) [ML] Report cause when datafeed extraction encounters error (elastic#66167) Remove suggest reference in some API specs (elastic#66180) Fix warning when installing a plugin for different ESversion (elastic#66146) [ML] make `xpack.ml.max_ml_node_size` and `xpack.ml.use_auto_machine_memory_percent` dynamically settable (elastic#66132) [DOCS] Add `require_alias` to Bulk API (elastic#66259) ...
Remove unsed fields in
RestAnalyzeAction