Extract DiskUsageIntegTestCase#65540
Merged
henningandersen merged 6 commits intoelastic:masterfrom Dec 4, 2020
Merged
Conversation
Extracted DiskUsageIntegTestCase from DiskThresholdDeciderIT to allow other tests to easily test functionality relying on disk usage. Relates elastic#65520
Collaborator
|
Pinging @elastic/es-distributed (Team:Distributed) |
Contributor
Author
|
Build failure looks like #65541 @elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
DaveCTurner
approved these changes
Dec 3, 2020
Member
DaveCTurner
left a comment
There was a problem hiding this comment.
LGTM with one comment nit
test/framework/src/main/java/org/elasticsearch/cluster/DiskUsageIntegTestCase.java
Outdated
Show resolved
Hide resolved
Co-authored-by: David Turner <david.turner@elastic.co>
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
1 similar comment
Contributor
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Dec 4, 2020
Extracted DiskUsageIntegTestCase from DiskThresholdDeciderIT to allow other tests to easily test functionality relying on disk usage. Relates elastic#65520
henningandersen
added a commit
that referenced
this pull request
Dec 4, 2020
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Dec 8, 2020
In elastic#65540, DiskUsageIntegTestCase was extracted. Unfortunately, the 7.x backport (elastic#65868) removed the handling of the nodes/0 folder, reintroduced here. Closes elastic#65946
henningandersen
added a commit
that referenced
this pull request
Dec 8, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted DiskUsageIntegTestCase from DiskThresholdDeciderIT to allow
other tests to easily test functionality relying on disk usage.
Relates #65520