Skip to content

[DOCS] Label legacy rollup APIs#65518

Merged
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__label-legacy-rollups
Dec 1, 2020
Merged

[DOCS] Label legacy rollup APIs#65518
jrodewig merged 1 commit intoelastic:masterfrom
jrodewig:docs__label-legacy-rollups

Conversation

@jrodewig
Copy link
Copy Markdown
Contributor

@jrodewig jrodewig commented Nov 25, 2020

@jrodewig jrodewig added >docs General docs changes >non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data v8.0.0 v7.11.0 labels Nov 25, 2020

// tag::legacy-rollup-admon[]
WARNING: This documentation is about legacy rollups. Legacy rollups are
deprecated and will be replaced by new rollup functionality introduced in {es}
Copy link
Copy Markdown
Contributor Author

@jrodewig jrodewig Nov 25, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to add an xref to the updated overview page once that's ready. I've added a note to #65515.

I don't think that's a blocker for this PR tho.

@jrodewig jrodewig mentioned this pull request Nov 25, 2020
26 tasks
@jrodewig jrodewig requested a review from talevy November 30, 2020 14:54
@jrodewig jrodewig marked this pull request as ready for review November 30, 2020 14:54
@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team labels Nov 30, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (Team:Analytics)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (Team:Docs)


experimental[]

endif::[]
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little confused. is the above header also in a second ifndef::permanently-unreleased-branch?

Copy link
Copy Markdown
Contributor Author

@jrodewig jrodewig Nov 30, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. I should have explained this better.

There are two conditionals: ifdef and ifndef. The content inside ifdef only displays on the master and 7.x branches (permanently unreleased branches). The content inside ifndef displays on all other branches.

This lets us use the same source when 7.n is cut from 7.x. Though the source will be the same, 7.x will use the ifdef content while 7.n will use the ifndef content.

When we get near release, I'll go through the docs and remove all the conditionals so only the ifdef content is left. I have a task for that over in #65515.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh ok. thanks for the clarification

@talevy talevy self-requested a review November 30, 2020 22:49
@jrodewig jrodewig merged commit eac2104 into elastic:master Dec 1, 2020
@jrodewig jrodewig deleted the docs__label-legacy-rollups branch December 1, 2020 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>docs General docs changes >non-issue :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team v7.11.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants