Support unmapped fields in search 'fields' option#65386
Merged
cbuescher merged 10 commits intoelastic:masterfrom Dec 1, 2020
Merged
Support unmapped fields in search 'fields' option#65386cbuescher merged 10 commits intoelastic:masterfrom
cbuescher merged 10 commits intoelastic:masterfrom
Conversation
added 2 commits
November 23, 2020 16:40
Currently, the 'fields' option only supports fetching mapped fields. Since 'fields' is meant to be the central place to retrieve document content, it should allow for loading unmapped values. This change adds implementation and tests for this feature. Closes elastic#63690
Collaborator
|
Pinging @elastic/es-search (Team:Search) |
3193e0d to
81b05d3
Compare
81b05d3 to
7bb350e
Compare
8 tasks
jtibshirani
reviewed
Nov 26, 2020
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
The overall approach looks good to me, I left some detailed comments.
docs/reference/search/search-your-data/retrieve-selected-fields.asciidoc
Outdated
Show resolved
Hide resolved
docs/reference/search/search-your-data/retrieve-selected-fields.asciidoc
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/fetch/subphase/FieldAndFormat.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/search/SearchRequestBuilder.java
Outdated
Show resolved
Hide resolved
x-pack/plugin/src/test/resources/rest-api-spec/test/flattened/10_basic.yml
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/fetch/subphase/FieldFetcher.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/fetch/subphase/FieldFetcher.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/fetch/subphase/FieldFetcher.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Show resolved
Hide resolved
Member
Author
|
@jtibshirani thanks a lot for your review so far, I pushed an update that should address your comments. |
jtibshirani
reviewed
Dec 1, 2020
server/src/main/java/org/elasticsearch/search/fetch/subphase/FieldFetcher.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/search/fetch/subphase/FieldFetcher.java
Outdated
Show resolved
Hide resolved
jtibshirani
reviewed
Dec 1, 2020
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
I left some small final comments (accidentally split across two reviews).
server/src/test/java/org/elasticsearch/search/fetch/subphase/FieldFetcherTests.java
Show resolved
Hide resolved
Member
Author
|
@jtibshirani I pushed another update to the branch and think I adressed your additional comments, thanks. Anything else you think needs doing here before merging? |
jtibshirani
approved these changes
Dec 1, 2020
Contributor
jtibshirani
left a comment
There was a problem hiding this comment.
This looks good to me. I left one last note about an open comment, but it looks ready to merge after we sort that out.
jtibshirani
approved these changes
Dec 1, 2020
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Dec 1, 2020
Currently, the 'fields' option only supports fetching mapped fields. Since 'fields' is meant to be the central place to retrieve document content, it should allow for loading unmapped values. This change adds implementation and tests for this feature. Closes elastic#63690
cbuescher
pushed a commit
that referenced
this pull request
Dec 3, 2020
Currently, the 'fields' option only supports fetching mapped fields. Since 'fields' is meant to be the central place to retrieve document content, it should allow for loading unmapped values. This change adds implementation and tests for this feature. Closes #63690
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, the 'fields' option only supports fetching mapped fields. Since
'fields' is meant to be the central place to retrieve document content, it
should allow for loading unmapped values. This change adds implementation and
tests for this feature.
Closes #63690