Skip to content

Remove deprecated code#64817

Merged
nik9000 merged 3 commits intoelastic:masterfrom
nik9000:drop_merging_buckets_collector
Nov 11, 2020
Merged

Remove deprecated code#64817
nik9000 merged 3 commits intoelastic:masterfrom
nik9000:drop_merging_buckets_collector

Conversation

@nik9000
Copy link
Copy Markdown
Member

@nik9000 nik9000 commented Nov 9, 2020

Removes MergingBucketsDeferringCollector which I deprecated in #64366.

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Aggregations)

@elasticmachine elasticmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Nov 9, 2020
Removes `MergingBucketsDeferringCollector` which I deprecated in elastic#64366.
Copy link
Copy Markdown
Member

@not-napoleon not-napoleon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@not-napoleon
Copy link
Copy Markdown
Member

Change looks fine assuming there are no real test failures after you fix the compile issue.

@nik9000
Copy link
Copy Markdown
Member Author

nik9000 commented Nov 10, 2020

Change looks fine assuming there are no real test failures after you fix the compile issue.

I could have swarn I compiled this locally. Oh well. I've made worse mistakes.

@nik9000 nik9000 merged commit 0d4c2d1 into elastic:master Nov 11, 2020
nik9000 added a commit to nik9000/elasticsearch that referenced this pull request Nov 11, 2020
Removes `MergingBucketsDeferringCollector` which I deprecated in elastic#64366.
nik9000 added a commit that referenced this pull request Nov 11, 2020
Removes `MergingBucketsDeferringCollector` which I deprecated in #64366.
@nik9000 nik9000 removed the backport label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Aggregations Aggregations >refactoring Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) v7.11.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants