Skip to content

Fix the earliest last modified age of translog issue.#64753

Merged
dnhatn merged 6 commits intoelastic:masterfrom
TencentCloudES:modify_time
Nov 26, 2020
Merged

Fix the earliest last modified age of translog issue.#64753
dnhatn merged 6 commits intoelastic:masterfrom
TencentCloudES:modify_time

Conversation

@howardhuanghua
Copy link
Copy Markdown
Contributor

@howardhuanghua howardhuanghua commented Nov 8, 2020 •
edited by dnhatn
Loading

Currently translog's earliest_last_modified_age field is always 0 in _nodes/stats response.

GET _nodes/stats?pretty
Response:
....
 "translog" : {
      "operations" : 87590,
      "size_in_bytes" : 181674457,
      "uncommitted_operations" : 87590,
      "uncommitted_size_in_bytes" : 181674457,
      "earliest_last_modified_age" : 0
    },
....

@howardhuanghua howardhuanghua mentioned this pull request Nov 25, 2020
Merged
@matriv matriv added the :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. label Nov 25, 2020
@elasticmachine elasticmachine added the Team:Distributed Meta label for distributed team. label Nov 25, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

elasticmachine commented Nov 25, 2020

Pinging @elastic/es-distributed (Team:Distributed)

dnhatn
dnhatn reviewed Nov 25, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @howardhuanghua. I prefer fixing the issue when adding a translog stats instead.

@howardhuanghua
Copy link
Copy Markdown
Contributor Author

howardhuanghua commented Nov 25, 2020

Thanks @dnhatn , you mean add a extra check to this.earliestLastModifiedAge, if it's 0L then set this.earliestLastModifiedAge = translogStats.earliestLastModifiedAge directly? Why would we just give a max long initial value for this.earliestLastModifiedAge? It seems much more simple.

@dnhatn
Copy link
Copy Markdown
Member

dnhatn commented Nov 25, 2020

Yes, but 0L is more appropriate than Long.MAX_VALUE for the timestamp of an empty translog.

@howardhuanghua
Copy link
Copy Markdown
Contributor Author

howardhuanghua commented Nov 26, 2020

Hi @dnhatn, I have updated the change, please help to review again, thanks.

dnhatn
dnhatn reviewed Nov 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @howardhuanghua. I left a small comment.

server/src/main/java/org/elasticsearch/index/translog/TranslogStats.java Outdated
this.uncommittedSizeInBytes += translogStats.uncommittedSizeInBytes;
this.earliestLastModifiedAge =
Math.min(this.earliestLastModifiedAge, translogStats.earliestLastModifiedAge);
if (this.earliestLastModifiedAge < 1) {
Copy link
Copy Markdown
Member

@dnhatn dnhatn Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use this.earliestLastModifiedAge == 0.

Copy link
Copy Markdown
Contributor Author

@howardhuanghua howardhuanghua Nov 26, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated, thanks.

@dnhatn
Copy link
Copy Markdown
Member

dnhatn commented Nov 26, 2020

@elasticmachine ok to test

dnhatn
dnhatn approved these changes Nov 26, 2020
View reviewed changes
Copy link
Copy Markdown
Member

@dnhatn dnhatn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @howardhuanghua.

@dnhatn dnhatn merged commit 7f4ead9 into elastic:master Nov 26, 2020
dnhatn pushed a commit that referenced this pull request Nov 30, 2020
@howardhuanghua @dnhatn
Fix the earliest last modified age of translog stats (#64753)
a4e3c68 
Currently translog's `earliest_last_modified_age` field is always 0 in `_nodes/stats` response.
dnhatn pushed a commit that referenced this pull request Nov 30, 2020
@howardhuanghua @dnhatn
Fix the earliest last modified age of translog stats (#64753)
0137c16 
Currently translog's `earliest_last_modified_age` field is always 0 in `_nodes/stats` response.
dnhatn pushed a commit that referenced this pull request Nov 30, 2020
@howardhuanghua @dnhatn
Fix the earliest last modified age of translog stats (#64753)
247e7c8 
Currently translog's `earliest_last_modified_age` field is always 0 in `_nodes/stats` response.
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dnhatn dnhatn dnhatn approved these changes

Assignees

No one assigned

Labels

>bug :Distributed/Engine Anything around managing Lucene and the Translog in an open shard. Team:Distributed Meta label for distributed team. v6.1.5 v7.10.2 v7.11.0 v8.0.0-alpha1

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@howardhuanghua @elasticmachine @dnhatn @jakelandis @matriv