[7.x] Add doc_count field mapper#64594
Merged
csoulios merged 12 commits intoelastic:7.xfrom Nov 6, 2020
Merged
Conversation
Bucket aggregations compute bucket doc_count values by incrementing the doc_count by 1 for every document collected in the bucket. When using summary fields (such as aggregate_metric_double) one field may represent more than one document. To provide this functionality we have implemented a new field mapper (named doc_count field mapper). This field is a positive integer representing the number of documents aggregated in a single summary field. Bucket aggregations will check if a field of type doc_count exists in a document and will take this value into consideration when computing doc counts.
Contributor
|
heya, heads up that you will need to adapt the valueFetcher method to take a QueryShardContext instead MapperService as argument, following #64524 . Our streams have crossed in master and it caused an interesting situation where both our builds were green yet the code after the two merges would not compile :) |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
Contributor
Author
|
@elasticmachine run elasticsearch-ci/bwc |
csoulios
added a commit
to csoulios/elasticsearch
that referenced
this pull request
Nov 6, 2020
After merging _doc_count PR in 7.x (elastic#64594), we can enable the skipped ML dataframe analytics. Those tests had been broken after merging elastic#64503 in master
csoulios
added a commit
that referenced
this pull request
Nov 6, 2020
csoulios
added a commit
that referenced
this pull request
Dec 3, 2020
csoulios
added a commit
that referenced
this pull request
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backports #64503 to 7.x