SignificantText aggregation had include/exclude logic back to front#64520
Merged
markharwood merged 3 commits intoelastic:masterfrom Nov 3, 2020
Merged
SignificantText aggregation had include/exclude logic back to front#64520markharwood merged 3 commits intoelastic:masterfrom
markharwood merged 3 commits intoelastic:masterfrom
Conversation
romseygeek
requested changes
Nov 3, 2020
.../java/org/elasticsearch/search/aggregations/bucket/terms/SignificantTextAggregatorTests.java
Outdated
Show resolved
Hide resolved
romseygeek
approved these changes
Nov 3, 2020
Contributor
romseygeek
left a comment
There was a problem hiding this comment.
LGTM! Thanks @markharwood
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Nov 3, 2020
…lastic#64520) SignificantText aggregation had include/exclude logic back to front. Added test. Closes elastic#64519
markharwood
added a commit
to markharwood/elasticsearch
that referenced
this pull request
Nov 3, 2020
…lastic#64520) SignificantText aggregation had include/exclude logic back to front. Added test. Closes elastic#64519
markharwood
added a commit
that referenced
this pull request
Nov 3, 2020
markharwood
added a commit
that referenced
this pull request
Nov 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SignificantTextAggregatorFactory had
IncludeExclude.accept() == truecondition when== falserequired.Added test.
Closes #64519