Adding API for generating SAML SP metadata#64517
Merged
BigPandaToo merged 14 commits intoelastic:masterfrom Nov 6, 2020
Merged
Adding API for generating SAML SP metadata#64517BigPandaToo merged 14 commits intoelastic:masterfrom
BigPandaToo merged 14 commits intoelastic:masterfrom
Conversation
jkakavas
requested changes
Nov 3, 2020
Contributor
jkakavas
left a comment
There was a problem hiding this comment.
Added a few comments and suggestions
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSPMetadataAction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/security/action/saml/SamlSPMetadataRequest.java
Outdated
Show resolved
Hide resolved
.../security/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlMetadataCommand.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSPMetadataAction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSPMetadataAction.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSPMetadataAction.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
tvernum
reviewed
Nov 4, 2020
...re/src/main/java/org/elasticsearch/xpack/core/security/action/saml/SamlSpMetadataAction.java
Outdated
Show resolved
Hide resolved
...e/src/main/java/org/elasticsearch/xpack/core/security/action/saml/SamlSpMetadataRequest.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Nov 4, 2020
...y/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlEntityDescriptorBuilder.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Nov 4, 2020
...y/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlEntityDescriptorBuilder.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Nov 4, 2020
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSpMetadataAction.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Nov 4, 2020
...e/src/main/java/org/elasticsearch/xpack/core/security/action/saml/SamlSpMetadataRequest.java
Outdated
Show resolved
Hide resolved
jkakavas
reviewed
Nov 4, 2020
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSpMetadataAction.java
Outdated
Show resolved
Hide resolved
jkakavas
requested changes
Nov 4, 2020
Contributor
jkakavas
left a comment
There was a problem hiding this comment.
My comment on the builder was too vague, I should have mentioned that we can use the SamlSpMetadataBuilder
Contributor
Author
|
@elasticmachine update branch |
jkakavas
requested changes
Nov 4, 2020
Contributor
jkakavas
left a comment
There was a problem hiding this comment.
Looking good @BigPandaToo , just a few final comments, thanks for the iterations!
...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java
Outdated
Show resolved
Hide resolved
...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/rest/action/saml/RestSamlSpMetadataAction.java
Outdated
Show resolved
Hide resolved
.../security/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlMetadataCommand.java
Outdated
Show resolved
Hide resolved
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSpMetadataAction.java
Outdated
Show resolved
Hide resolved
...re/src/main/java/org/elasticsearch/xpack/core/security/action/saml/SamlSpMetadataAction.java
Show resolved
Hide resolved
Contributor
Author
|
@elasticmachine update branch |
Contributor
Author
|
@elasticmachine update branch |
Collaborator
|
expected head sha didn’t match current head ref. |
added 2 commits
November 5, 2020 12:50
Contributor
Author
|
Just submitted the change |
jkakavas
approved these changes
Nov 5, 2020
Contributor
jkakavas
left a comment
There was a problem hiding this comment.
A few nits, feel free to merge after addressing those! Thanks @BigPandaToo
...rc/main/java/org/elasticsearch/xpack/security/action/saml/TransportSamlSpMetadataAction.java
Outdated
Show resolved
Hide resolved
...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java
Outdated
Show resolved
Hide resolved
...ecurity/src/main/java/org/elasticsearch/xpack/security/authc/saml/SamlSpMetadataBuilder.java
Outdated
Show resolved
Hide resolved
BigPandaToo
added a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 6, 2020
* Adding API for generating SAML SP metadata Resolve elastic#49018 * Adding API for generating SAML SP metadata Resolves elastic#49018 * Adding API for generating SAML SP metadata Resolves elastic#49018 * Adding API for generating SAML SP metadata Resolves elastic#49018 * Adding API for generating SAML SP metadata Resolves elastic#49018 * Adding API for generating SAML SP metadata Resolves elastic#49018 * Adding API for generating SAML SP metadata Resolves elastic#49018 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
BigPandaToo
added a commit
that referenced
this pull request
Nov 6, 2020
* Adding API for generating SAML SP metadata Resolve #49018 * Adding API for generating SAML SP metadata Resolves #49018 * Adding API for generating SAML SP metadata Resolves #49018 * Adding API for generating SAML SP metadata Resolves #49018 * Adding API for generating SAML SP metadata Resolves #49018 * Adding API for generating SAML SP metadata Resolves #49018 * Adding API for generating SAML SP metadata Resolves #49018 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
BigPandaToo
pushed a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 16, 2020
…aml/metadata/{realm}
Related to elastic#49018
BigPandaToo
pushed a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 16, 2020
…aml/metadata/{realm}
Related to elastic#49018
BigPandaToo
pushed a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 16, 2020
…aml/metadata/{realm}
Related to elastic#49018
BigPandaToo
pushed a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 16, 2020
…aml/metadata/{realm}
Related to elastic#49018
BigPandaToo
pushed a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 16, 2020
…aml/metadata/{realm}
Related to elastic#49018
Collaborator
|
Pinging @elastic/es-security (Team:Security) |
BigPandaToo
pushed a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 17, 2020
…aml/metadata/{realm}
Related to elastic#49018
BigPandaToo
added a commit
that referenced
this pull request
Nov 17, 2020
…adata/{realm} (#65065)
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* [DOCS] Adds API to navigation tree
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
Co-authored-by: lcawl <lcawley@elastic.co>
BigPandaToo
added a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 17, 2020
…aml/metadata/{realm} (elastic#65065)
* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}
Related to elastic#49018
* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}
Related to elastic#49018
* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}
Related to elastic#49018
* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves elastic#53161
* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}
Related to elastic#49018
* [DOCS] Adds API to navigation tree
* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}
Related to elastic#49018
* Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm}
Related to elastic#49018
Co-authored-by: lcawl <lcawley@elastic.co>
BigPandaToo
added a commit
that referenced
this pull request
Nov 17, 2020
…adata/{realm} (#65065) (#65158)
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm} (#65065)
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* [DOCS] Adds API to navigation tree
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
* Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm}
Related to #49018
Co-authored-by: lcawl <lcawley@elastic.co>
* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161
Co-authored-by: lcawl lcawley@elastic.co
#65065
#backport
* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161
Co-authored-by: lcawl lcawley@elastic.co
#65065
#backport
* This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs
Resolves #53161
Co-authored-by: lcawl lcawley@elastic.co
#65065
#backport
Co-authored-by: lcawl <lcawley@elastic.co>
BigPandaToo
pushed a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Nov 17, 2020
…aml/metadata/{realm}
Related to elastic#49018
BigPandaToo
added a commit
that referenced
this pull request
Dec 4, 2020
* This change adds a warning header when a license is about to expire Resolves #60562 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves #53161 * Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm} Related to #49018 * Adding a warning header when a license is about to expire Resolves #60562 * Addressing the PR feedback * Switching back to adding the header during featureCheck to allow warnings when authentication is disabled as well. Adding filterHeader implementation to SecurityRestFilter exception handling to remove all the warnings if authentication fails. * Changing the wording for "expired" message to be consistent with the log messages; changing "today" calculation; adding a test case for failing authN to make sure we remove the warning header * Small changes in the way we verify header in tests * Nit changes Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
BigPandaToo
added a commit
to BigPandaToo/elasticsearch
that referenced
this pull request
Dec 4, 2020
) * This change adds a warning header when a license is about to expire Resolves elastic#60562 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves elastic#53161 * Adding doc for the new API introduced by elastic#64517 - /_security/saml/metadata/{realm} Related to elastic#49018 * Adding a warning header when a license is about to expire Resolves elastic#60562 * Addressing the PR feedback * Switching back to adding the header during featureCheck to allow warnings when authentication is disabled as well. Adding filterHeader implementation to SecurityRestFilter exception handling to remove all the warnings if authentication fails. * Changing the wording for "expired" message to be consistent with the log messages; changing "today" calculation; adding a test case for failing authN to make sure we remove the warning header * Small changes in the way we verify header in tests * Nit changes Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
BigPandaToo
added a commit
that referenced
this pull request
Dec 5, 2020
) * Adding a warning header when a license is about to expire (#64948) * This change adds a warning header when a license is about to expire Resolves #60562 * This change adds realm name of the realm used to perform authentication to the responses of _security/oidc/authenticate and _security/oidc/authenticate APIs Resolves #53161 * Adding doc for the new API introduced by #64517 - /_security/saml/metadata/{realm} Related to #49018 * Adding a warning header when a license is about to expire Resolves #60562 * Addressing the PR feedback * Switching back to adding the header during featureCheck to allow warnings when authentication is disabled as well. Adding filterHeader implementation to SecurityRestFilter exception handling to remove all the warnings if authentication fails. * Changing the wording for "expired" message to be consistent with the log messages; changing "today" calculation; adding a test case for failing authN to make sure we remove the warning header * Small changes in the way we verify header in tests * Nit changes Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> * Resolving backporting issue: adding copyMapWithRemovedEntry() util function Fixing unused imports Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding API for generating SAML SP metadata
Resolves #49018