Enable geo_distance and geo_bounding_box queries on geo_shape field type#64224
Merged
iverase merged 5 commits intoelastic:masterfrom Oct 29, 2020
Merged
Enable geo_distance and geo_bounding_box queries on geo_shape field type#64224iverase merged 5 commits intoelastic:masterfrom
iverase merged 5 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Geo) |
Closed
jrodewig
suggested changes
Oct 28, 2020
Contributor
jrodewig
left a comment
There was a problem hiding this comment.
This looks good overall. However, there are some grammar issues that need to be fixed before a merge. It also looks like a few of the example snippets target the wrong indices.
Contributor
Author
|
Thanks you @jrodewig, I added your suggestions! |
jrodewig
approved these changes
Oct 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit enables geo_distance and geo_bounding_box queries on geo_shape field type. In addition it enables those queries over geo_point runtime fields as well.
closes #54628