Skip to content

[ML] Support the unsigned_long type in data frame analytics#64066

Merged
droberts195 merged 2 commits intoelastic:masterfrom
droberts195:support_unsigned_long_in_dfa
Oct 22, 2020
Merged

[ML] Support the unsigned_long type in data frame analytics#64066
droberts195 merged 2 commits intoelastic:masterfrom
droberts195:support_unsigned_long_in_dfa

Conversation

@droberts195
Copy link
Copy Markdown

Adds support for the unsigned_long type to data frame analytics.

This type is handled in the same way as the long type. Values
sent to the ML native processes are converted to floats and
hence will lose accuracy when outside the range where a float
can uniquely represent long values.

Relates #60050

Adds support for the unsigned_long type to data frame analytics.

This type is handled in the same way as the long type.  Values
sent to the ML native processes are converted to floats and
hence will lose accuracy when outside the range where a float
can uniquely represent long values.

Relates elastic#60050
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (:ml)

@droberts195
Copy link
Copy Markdown
Author

I marked this as a >non-issue because #60050 is already release-noted and arguably this change should have been part of that, so doesn't need a separate release note.

Copy link
Copy Markdown
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@droberts195 droberts195 merged commit 55fe93e into elastic:master Oct 22, 2020
@droberts195 droberts195 deleted the support_unsigned_long_in_dfa branch October 22, 2020 15:41
droberts195 added a commit to droberts195/elasticsearch that referenced this pull request Oct 22, 2020
Adds support for the unsigned_long type to data frame analytics.

This type is handled in the same way as the long type.  Values
sent to the ML native processes are converted to floats and
hence will lose accuracy when outside the range where a float
can uniquely represent long values.

Backport of elastic#64066
droberts195 added a commit that referenced this pull request Oct 26, 2020
Adds support for the unsigned_long type to data frame analytics.

This type is handled in the same way as the long type.  Values
sent to the ML native processes are converted to floats and
hence will lose accuracy when outside the range where a float
can uniquely represent long values.

Backport of #64066
droberts195 added a commit that referenced this pull request Oct 26, 2020
Adds support for the unsigned_long type to data frame analytics.

This type is handled in the same way as the long type.  Values
sent to the ML native processes are converted to floats and
hence will lose accuracy when outside the range where a float
can uniquely represent long values.

Backport of #64066
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants