Drop boost from runtime distance feature query#63949
Merged
nik9000 merged 1 commit intoelastic:masterfrom Oct 21, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
This drops the `boost` parameter of the `distance_feature` query builder internally, relying on our query building infrastructure to wrap the query in a `boosting` query. Relates to elastic#63767
mayya-sharipova
approved these changes
Oct 21, 2020
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
@nik9000 Thanks for this, LGTM!
Member
Author
|
Thanks for reviewing @mayya-sharipova ! |
nik9000
added a commit
to nik9000/elasticsearch
that referenced
this pull request
Oct 21, 2020
This drops the `boost` parameter of the `distance_feature` query builder internally, relying on our query building infrastructure to wrap the query in a `boosting` query. Relates to elastic#63767
nik9000
added a commit
that referenced
this pull request
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This drops the
boostparameter of thedistance_featurequery builderinternally, relying on our query building infrastructure to wrap the
query in a
boostingquery.Relates to #63767