Convert WildcardFieldMapper to parametrized form#63465
Merged
romseygeek merged 4 commits intoelastic:masterfrom Oct 13, 2020
Merged
Convert WildcardFieldMapper to parametrized form#63465romseygeek merged 4 commits intoelastic:masterfrom
romseygeek merged 4 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
28 tasks
Contributor
Author
|
@elasticmachine update branch |
cbuescher
approved these changes
Oct 13, 2020
Member
cbuescher
left a comment
There was a problem hiding this comment.
LGTM, I left two questions for my own education though.
| return q instanceof MatchAllDocsQuery || q instanceof MatchAllButRequireVerificationQuery; | ||
| } | ||
|
|
||
| protected String firstNgramToken(String fragment, Analyzer analyzer) { |
Contributor
Author
There was a problem hiding this comment.
Yes, IntelliJ flagged it up as never called
| throw new MapperParsingException("The field [" + name + "] cannot have indexOptions = " + indexOptions); | ||
| } | ||
| return this; | ||
| } |
Member
There was a problem hiding this comment.
Just curious because haven't reviews that many of these moves to ParametrizedFieldMapper yet: These errors woll now happen automatically if no Parameter is defined?
Contributor
Author
There was a problem hiding this comment.
Yes, for previously 'global' parameters that don't really make sense on a mapper, you'll get a deprecation warning in 7x and an error in master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relates to #62988