[ML] adding result_type and mlcategory fields to category definitions#63326
Merged
benwtrent merged 2 commits intoelastic:masterfrom Oct 7, 2020
Merged
[ML] adding result_type and mlcategory fields to category definitions#63326benwtrent merged 2 commits intoelastic:masterfrom
benwtrent merged 2 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/ml-core (:ml) |
Member
Author
|
I opted to not add these fields to the HLRC as they don't seem to add any value there. Especially since result type would just be ignored and mlcategory is simply category_id. |
droberts195
reviewed
Oct 6, 2020
...lugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/results/CategoryDefinition.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/results/CategoryDefinition.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/results/ReservedFieldNames.java
Outdated
Show resolved
Hide resolved
...lugin/core/src/main/java/org/elasticsearch/xpack/core/ml/job/results/CategoryDefinition.java
Show resolved
Hide resolved
Member
Author
|
run elasticsearch-ci/packaging-sample-windows |
droberts195
approved these changes
Oct 7, 2020
droberts195
left a comment
There was a problem hiding this comment.
LGTM
I changed the label from >non-issue to >enhancement, as I think some people would find this interesting to know about.
benwtrent
added a commit
to benwtrent/elasticsearch
that referenced
this pull request
Oct 7, 2020
…elastic#63326) To easy correlation between anomaly results and category definitions, this commit adds a new keyword mapped field `mlcategory`. This field is always the same as the `category_id` field (which is mapped as a long). But since anomaly results store the `mlcategory` as a keyword, it simplifies queries if category_definitions also had this field as a keyword. The stored JSON is a `string`. Additionally, this commit adds a `result_type: category_definition` entry to category definition documents. This will help simplify and unify result queries in the future. closes elastic#60108
benwtrent
added a commit
that referenced
this pull request
Oct 8, 2020
…#63326) (#63412) To easy correlation between anomaly results and category definitions, this commit adds a new keyword mapped field `mlcategory`. This field is always the same as the `category_id` field (which is mapped as a long). But since anomaly results store the `mlcategory` as a keyword, it simplifies queries if category_definitions also had this field as a keyword. The stored JSON is a `string`. Additionally, this commit adds a `result_type: category_definition` entry to category definition documents. This will help simplify and unify result queries in the future. closes #60108 Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To easy correlation between anomaly results and category definitions, this commit adds a new keyword mapped field
mlcategory.This field is always the same as the
category_idfield (which is mapped as a long). But since anomaly results storethe
mlcategoryas a keyword, it simplifies queries if category_definitions also had this field as a keyword.The stored JSON is a
string.Additionally, this commit adds a
result_type: category_definitionentry to category definition documents.This will help simplify and unify result queries in the future.
closes #60108