Convert dense/sparse vector field mappers to Parametrized form#62992
Merged
romseygeek merged 3 commits intoelastic:masterfrom Sep 30, 2020
Merged
Convert dense/sparse vector field mappers to Parametrized form#62992romseygeek merged 3 commits intoelastic:masterfrom
romseygeek merged 3 commits intoelastic:masterfrom
Conversation
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
28 tasks
Contributor
Author
|
@elasticmachine run elasticsearch-ci/2 (failure in ML, doesn't look related) |
mayya-sharipova
approved these changes
Sep 30, 2020
Contributor
mayya-sharipova
left a comment
There was a problem hiding this comment.
Thanks @romseygeek, this PR LGTM
romseygeek
added a commit
that referenced
this pull request
Sep 30, 2020
Also adds a proper MapperTestCase test for dense vectors. Relates to #62988
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also adds a proper MapperTestCase test for dense vectors.
Relates to #62988