Tweak the ECS fields in DeprecatedMessage#62855
Merged
pugnascotia merged 1 commit intoelastic:masterfrom Sep 24, 2020
Merged
Conversation
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Logging) |
ruflin
approved these changes
Sep 24, 2020
Contributor
ruflin
left a comment
There was a problem hiding this comment.
LGTM. I assume there is only 1 deprecation log for Elasticsearch?
Thanks for the adjustments.
At a later stage, the question is probably going to bubble up if the user should be able to configure the namespace but lets keep that for later ;-)
Contributor
Author
|
Well, there's a log file, and optionally the data stream, but there's only one route into emitting the log messages, so the contents of those locations will be the same. I'll worry about the namespace if it comes up 😅 |
Contributor
Author
|
Backported to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make a couple of changes to the ECS fields that are attached to log messages in
DeprecatedMessage, as suggested in #61484 (review).