Add index.routing.allocation.include._tier_preference setting#62589
Merged
dakrone merged 7 commits intoelastic:masterfrom Sep 18, 2020
Merged
Add index.routing.allocation.include._tier_preference setting#62589dakrone merged 7 commits intoelastic:masterfrom
dakrone merged 7 commits intoelastic:masterfrom
Conversation
This commit adds the `index.routing.allocation.prefer._tier` setting to the `DataTierAllocationDecider`. This special-purpose allocation setting lets a user specify a preference-based list of tiers for an index to be assigned to. For example, if the setting were set to: ``` "index.routing.allocation.prefer._tier": "data_hot,data_warm,data_content" ``` If the cluster contains any nodes with the `data_hot` role, the decider will only allow them to be allocated on the `data_hot` node(s). If there are no `data_hot` nodes, but there are `data_warm` and `data_content` nodes, then the index will be allowed to be allocated on `data_warm` nodes. This allows us to specify an index's preference for tier(s) without causing the index to be unassigned if no nodes of a preferred tier are available. Subsequent work will change the ILM migration to make additional use of this setting. Relates to elastic#60848
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Features) |
18 tasks
Member
Author
|
Since this setting is not part of the existing preference group, we need to handle backwards compatibility. I think we have a couple of options here:
|
andreidan
requested changes
Sep 18, 2020
Contributor
andreidan
left a comment
There was a problem hiding this comment.
Thanks for working on this Lee.
I've left a couple of rather minor suggestions.
Can you please add some tests to show illustrate the include/exclude/require precedence over preferred?
.../main/java/org/elasticsearch/xpack/cluster/routing/allocation/DataTierAllocationDecider.java
Outdated
Show resolved
Hide resolved
.../main/java/org/elasticsearch/xpack/cluster/routing/allocation/DataTierAllocationDecider.java
Outdated
Show resolved
Hide resolved
Member
Author
|
Thanks Andrei, I made the changes you suggested |
Member
Author
|
@elasticmachine run elasticsearch-ci/packaging-sample-windows |
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine test this please |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 18, 2020
This commit adds the `index.routing.allocation.prefer._tier` setting to the `DataTierAllocationDecider`. This special-purpose allocation setting lets a user specify a preference-based list of tiers for an index to be assigned to. For example, if the setting were set to: ``` "index.routing.allocation.prefer._tier": "data_hot,data_warm,data_content" ``` If the cluster contains any nodes with the `data_hot` role, the decider will only allow them to be allocated on the `data_hot` node(s). If there are no `data_hot` nodes, but there are `data_warm` and `data_content` nodes, then the index will be allowed to be allocated on `data_warm` nodes. This allows us to specify an index's preference for tier(s) without causing the index to be unassigned if no nodes of a preferred tier are available. Subsequent work will change the ILM migration to make additional use of this setting. Relates to elastic#60848
dakrone
added a commit
that referenced
this pull request
Sep 18, 2020
…62589) (#62667) This commit adds the `index.routing.allocation.prefer._tier` setting to the `DataTierAllocationDecider`. This special-purpose allocation setting lets a user specify a preference-based list of tiers for an index to be assigned to. For example, if the setting were set to: ``` "index.routing.allocation.prefer._tier": "data_hot,data_warm,data_content" ``` If the cluster contains any nodes with the `data_hot` role, the decider will only allow them to be allocated on the `data_hot` node(s). If there are no `data_hot` nodes, but there are `data_warm` and `data_content` nodes, then the index will be allowed to be allocated on `data_warm` nodes. This allows us to specify an index's preference for tier(s) without causing the index to be unassigned if no nodes of a preferred tier are available. Subsequent work will change the ILM migration to make additional use of this setting. Relates to #60848
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds the
index.routing.allocation.include._tier_preferencesetting to theDataTierAllocationDecider. This special-purpose allocation setting lets a user specify apreference-based list of tiers for an index to be assigned to. For example, if the setting were set
to:
If the cluster contains any nodes with the
data_hotrole, the decider will only allow them to beallocated on the
data_hotnode(s). If there are nodata_hotnodes, but there aredata_warmanddata_contentnodes, then the index will be allowed to be allocated ondata_warmnodes.This allows us to specify an index's preference for tier(s) without causing the index to be
unassigned if no nodes of a preferred tier are available.
Subsequent work will change the ILM migration to make additional use of this setting.
Relates to #60848