Add "synthetics-*-*" templates for synthetics fleet data#62193
Merged
dakrone merged 6 commits intoelastic:masterfrom Sep 14, 2020
Merged
Add "synthetics-*-*" templates for synthetics fleet data#62193dakrone merged 6 commits intoelastic:masterfrom
dakrone merged 6 commits intoelastic:masterfrom
Conversation
For the Elastic Agent we currently have `logs` and `metrics`, however, synthetic data doesn't belong with those and thus we should have a place for it to live. This would be data reported from heartbeat and under the 'monitoring' category. This commit adds a composable index template for `synthetics-*-*` indices similar to the work in elastic#56709 and elastic#57629. Resolves elastic#61665
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
andreidan
approved these changes
Sep 10, 2020
ruflin
reviewed
Sep 10, 2020
Contributor
ruflin
left a comment
There was a problem hiding this comment.
Overall LGTM but I want some others to chime in too.
| "hot": { | ||
| "actions": { | ||
| "rollover": { | ||
| "max_size": "50gb", |
Contributor
There was a problem hiding this comment.
@andrewvc I assume this also works for synthetics for now?
Contributor
There was a problem hiding this comment.
TBH we haven't done enough benchmarking to know, but it seems reasonable
| "priority": 100, | ||
| "data_stream": {}, | ||
| "composed_of": [ | ||
| "synthetics-mappings", |
Contributor
There was a problem hiding this comment.
@jpountz I remember you wanted to "not" use components here. Perhaps it is a good time to adjust?
Contributor
|
@ph @neptunian As soon as this lands, we also probably need to add a fake doc for the index pattern in Kibana. |
jpountz
approved these changes
Sep 14, 2020
There is no "message" field for this to be the default for
|
@ruflin if we expect to create an index pattern, like |
andrewvc
reviewed
Sep 14, 2020
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/2 |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 14, 2020
* Add "synthetics-*-*" templates for synthetics fleet data For the Elastic Agent we currently have `logs` and `metrics`, however, synthetic data doesn't belong with those and thus we should have a place for it to live. This would be data reported from heartbeat and under the 'monitoring' category. This commit adds a composable index template for `synthetics-*-*` indices similar to the work in elastic#56709 and elastic#57629. Resolves elastic#61665
dakrone
added a commit
that referenced
this pull request
Sep 14, 2020
… (#62346) * Add "synthetics-*-*" templates for synthetics fleet data For the Elastic Agent we currently have `logs` and `metrics`, however, synthetic data doesn't belong with those and thus we should have a place for it to live. This would be data reported from heartbeat and under the 'monitoring' category. This commit adds a composable index template for `synthetics-*-*` indices similar to the work in #56709 and #57629. Resolves #61665
Contributor
|
@neptunian SGTM |
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 15, 2020
We need to ensure these are mapped as 'ip' instead of a keyword, even if they do end up not being used. Relates to elastic#62193
dakrone
added a commit
to dakrone/elasticsearch
that referenced
this pull request
Sep 17, 2020
…astic#62412) We need to ensure these are mapped as 'ip' instead of a keyword, even if they do end up not being used. Relates to elastic#62193
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the Elastic Agent we currently have
logsandmetrics, however, synthetic data doesn't belongwith those and thus we should have a place for it to live. This would be data reported from
heartbeat and under the 'monitoring' category.
This commit adds a composable index template for
synthetics-*-*indices similar to the work in#56709 and #57629.
Resolves #61665