Add a snapshot test module to delay shard aggregations#62082
Merged
jimczi merged 1 commit intoelastic:masterfrom Sep 15, 2020
Merged
Add a snapshot test module to delay shard aggregations#62082jimczi merged 1 commit intoelastic:masterfrom
jimczi merged 1 commit intoelastic:masterfrom
Conversation
This change adds an aggregation that can be used to delay the
query phase execution on shards with a configurable time:
{
"aggs": {
"delay": {
"shard_delay": {
"value": "30s"
},
"aggs": {
"host": {
"terms": {
"field": "hostname"
}
}
}
}
}
}
This test module is built on top of elastic#61954 so the aggregation will be available only within
snapshots since this module is not meant to be used in production.
Closes elastic#54159
Collaborator
|
Pinging @elastic/es-core-infra (:Core/Infra/Build) |
Collaborator
|
Pinging @elastic/es-search (:Search/Search) |
jpountz
approved these changes
Sep 14, 2020
Contributor
jpountz
left a comment
There was a problem hiding this comment.
I like the simplicity of the approach. The reliance on wall clock means that you can't do much more automated testing besides making sure that everything keeps working with slow response times, but this still feels useful to me, and even more useful for manual testing.
2 tasks
jimczi
added a commit
that referenced
this pull request
Sep 15, 2020
This change adds an aggregation that can be used to delay the
query phase execution on shards with a configurable time:
{
"aggs": {
"delay": {
"shard_delay": {
"value": "30s"
},
"aggs": {
"host": {
"terms": {
"field": "hostname"
}
}
}
}
}
}
This test module is built on top of #61954 so the aggregation will be available only within
snapshots since this module is not meant to be used in production.
Closes #54159
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds an aggregation that can be used to delay the
query phase execution on shards with a configurable time:
This test module is built on top of #61954 so the aggregation will be available only within
snapshots since this module is not meant to be used in production.
Closes #54159