Dedicated threadpool for system index writes#61655
Merged
jaymode merged 11 commits intoelastic:masterfrom Sep 22, 2020
Merged
Conversation
This commit adds a dedicated threadpool for system index write operations. The dedicated resources for system index writes serves as a means to ensure that user activity does not block important system operations from occurring such as the management of users and roles.
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/CRUD) |
Contributor
|
You might want to force execution on |
AthenaEryma
approved these changes
Sep 1, 2020
Contributor
AthenaEryma
left a comment
There was a problem hiding this comment.
Left a few minor comments, LGTM otherwise (no need for another round of review once the comments are addressed). You may want a second opinion from someone more familiar with this code though - write threadpools are not my area of expertise.
server/src/main/java/org/elasticsearch/action/bulk/TransportBulkAction.java
Show resolved
Hide resolved
server/src/main/java/org/elasticsearch/action/support/replication/TransportWriteAction.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/action/bulk/TransportBulkActionIngestTests.java
Show resolved
Hide resolved
Tim-Brooks
approved these changes
Sep 21, 2020
Contributor
Tim-Brooks
left a comment
There was a problem hiding this comment.
LGTM - I only looked at the indexing pressure stuff in bulk action and shard bulk action. If you wanted a full review from me, let me know.
jaymode
added a commit
that referenced
this pull request
Sep 22, 2020
This commit adds a dedicated threadpool for system index write operations. The dedicated resources for system index writes serves as a means to ensure that user activity does not block important system operations from occurring such as the management of users and roles. Backport of #61655
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a dedicated threadpool for system index write
operations. The dedicated resources for system index writes serves as
a means to ensure that user activity does not block important system
operations from occurring such as the management of users and roles.