Skip to content

[DOCS] Update info about geo_shape bounding boxes#61214

Merged
lockewritesdocs merged 2 commits intoelastic:masterfrom
lockewritesdocs:docs__update-geo-bounds
Aug 17, 2020
Merged

[DOCS] Update info about geo_shape bounding boxes#61214
lockewritesdocs merged 2 commits intoelastic:masterfrom
lockewritesdocs:docs__update-geo-bounds

Conversation

@lockewritesdocs
Copy link
Copy Markdown
Contributor

@lockewritesdocs lockewritesdocs commented Aug 17, 2020

Per #55812, this PR adds clarifications around the geo_bounds aggregation where the top_left area of the bounding box can exceed the top_right.

Closes #55812

Backports:

@lockewritesdocs lockewritesdocs added >docs General docs changes :Analytics/Geo Indexing, search aggregations of geo points and shapes labels Aug 17, 2020
@lockewritesdocs lockewritesdocs self-assigned this Aug 17, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-docs (>docs)

@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/es-analytics-geo (:Analytics/Geo)

@elasticmachine elasticmachine added Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team labels Aug 17, 2020
Copy link
Copy Markdown
Contributor

@thomasneirynck thomasneirynck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 💯 @lockewritesdocs !


If <<geo-bounds-wrap-longitude,`wrap_longitude`>> is set to `true`
(the default), the bounding box can overlap the international date line. If
these shapes also include `geo_shape` fields, the `geo_bounds` aggregation
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this behavior applies equally to just points, so I think we can remove this if.

e.g.:

If <<geo-bounds-wrap-longitude,`wrap_longitude`>> is set to `true`
(the default), the bounding box can overlap the international date line and returns a bounds where the `top_left` longitude is larger than the `top_right` longitude.

@lockewritesdocs lockewritesdocs merged commit fdc867e into elastic:master Aug 17, 2020
@lockewritesdocs lockewritesdocs deleted the docs__update-geo-bounds branch August 17, 2020 15:07
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Aug 17, 2020
* Adding information about geo_shape bounding boxes.

* Fixing cross link and incorporating review feedback.
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Aug 17, 2020
* Adding information about geo_shape bounding boxes.

* Fixing cross link and incorporating review feedback.
lockewritesdocs pushed a commit to lockewritesdocs/elasticsearch that referenced this pull request Aug 17, 2020
* Adding information about geo_shape bounding boxes.

* Fixing cross link and incorporating review feedback.
lockewritesdocs pushed a commit that referenced this pull request Aug 17, 2020
* Adding information about geo_shape bounding boxes.

* Fixing cross link and incorporating review feedback.
lockewritesdocs pushed a commit that referenced this pull request Aug 17, 2020
* Adding information about geo_shape bounding boxes.

* Fixing cross link and incorporating review feedback.
lockewritesdocs pushed a commit that referenced this pull request Aug 17, 2020
* Adding information about geo_shape bounding boxes.

* Fixing cross link and incorporating review feedback.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:Analytics/Geo Indexing, search aggregations of geo points and shapes >docs General docs changes Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) Team:Docs Meta label for docs team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geo_bounds agg top_left longitude is larger than bottom_right longitude

3 participants