Fix the parent join aggregator test case#60991
Merged
nik9000 merged 1 commit intoelastic:masterfrom Aug 11, 2020
Merged
Conversation
The test was putting parent and child documents into different segments which is unrealistic and was causing errors. Closes elastic#60980
9b40902 to
d331afb
Compare
Collaborator
|
Pinging @elastic/es-analytics-geo (:Analytics/Aggregations) |
Member
Author
|
@jimczi we talked about copying each leaf and sending a real |
jimczi
approved these changes
Aug 11, 2020
Contributor
jimczi
left a comment
There was a problem hiding this comment.
Very nice! Thanks for fixing.
nik9000
added a commit
that referenced
this pull request
Aug 11, 2020
The test was putting parent and child documents into different segments which is unrealistic and was causing errors. Closes #60980
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was putting parent and child documents into different segments
which is unrealistic and was causing errors.
Closes #60980