Improve error message in case of invalid dynamic templates#60870
Merged
martijnvg merged 6 commits intoelastic:masterfrom Nov 12, 2020
Merged
Conversation
Include the attempted 'match_mapping_type' into the message, so that it is clearer that multiple validation attempts have occurred. Dynamic template validation was recently added via elastic#51233 and there was some confusion over the deprecation message itself. (in 7.x only deprecation warning will be omitted and from 8.0 an error will be returned)
Collaborator
|
Pinging @elastic/es-search (:Search/Mapping) |
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/Indices APIs) |
danhermann
approved these changes
Sep 3, 2020
Contributor
danhermann
left a comment
There was a problem hiding this comment.
LGTM. Two minor comments for your consideration.
| String message = String.format(Locale.ROOT, "dynamic template [%s] has invalid content [%s]", | ||
| dynamicTemplate.getName(), Strings.toString(dynamicTemplate)); | ||
| String format = "dynamic template [%s] has invalid content [%s], " + | ||
| "attempted to validate it with the following [match_mapping_type]: [%s]"; |
Contributor
There was a problem hiding this comment.
Don't error messages usually use square brackets around values rather than names? In other words, should there be square brackets around match_mapping_type?
Member
Author
There was a problem hiding this comment.
You're right, I don't think so.
Co-authored-by: Dan Hermann <danhermann@users.noreply.github.com>
Member
Author
|
@elasticmachine update branch |
Member
Author
|
@elasticmachine run elasticsearch-ci/docs |
martijnvg
added a commit
to martijnvg/elasticsearch
that referenced
this pull request
Nov 12, 2020
Backporting elastic#60870 to 7.x branch. Include the attempted 'match_mapping_type' into the message, so that it is clearer that multiple validation attempts have occurred. Dynamic template validation was recently added via elastic#51233 and there was some confusion over the deprecation message itself. (in 7.x only deprecation warning will be omitted and from 8.0 an error will be returned)
martijnvg
added a commit
that referenced
this pull request
Nov 12, 2020
Backporting #60870 to 7.x branch. Include the attempted 'match_mapping_type' into the message, so that it is clearer that multiple validation attempts have occurred. Dynamic template validation was recently added via #51233 and there was some confusion over the deprecation message itself. (in 7.x only deprecation warning will be omitted and from 8.0 an error will be returned)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Include the attempted 'match_mapping_type' into the message,
so that it is clearer that multiple validation attempts have occurred.
Dynamic template validation was recently added via #51233 and
there was some confusion over the deprecation message itself.
(in 7.x only deprecation warning will be omitted and from 8.0
an error will be returned)