Fix testRerouteOccursOnDiskPassingHighWatermark#60869
Merged
DaveCTurner merged 3 commits intoelastic:masterfrom Aug 10, 2020
Merged
Conversation
Sometimes this test would refresh the disk stats so quickly that it hit the refresh rate limiter even though it was almost completely disabled. This commit allows the rate limiter to be completely disabled. Closes elastic#60587
Collaborator
|
Pinging @elastic/es-distributed (:Distributed/Allocation) |
DaveCTurner
added a commit
that referenced
this pull request
Aug 10, 2020
Sometimes this test would refresh the disk stats so quickly that it hit the refresh rate limiter even though it was almost completely disabled. This commit allows the rate limiter to be completely disabled. Closes #60587
DaveCTurner
added a commit
that referenced
this pull request
Aug 10, 2020
Sometimes this test would refresh the disk stats so quickly that it hit the refresh rate limiter even though it was almost completely disabled. This commit allows the rate limiter to be completely disabled. Closes #60587
DaveCTurner
added a commit
to DaveCTurner/elasticsearch
that referenced
this pull request
Apr 27, 2021
We reroute when the elapsed time is >= 60000ms, but the test assumes that no reroute happens exactly at 60000ms. This commit fixes this off-by-one-ms error. Relates elastic#60869 which introduced this test issue Relates elastic#68316 which mostly fixed this test issue except this one spot Closes elastic#71424
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes this test would refresh the disk stats so quickly that it hit
the refresh rate limiter even though it was almost completely disabled.
This commit allows the rate limiter to be completely disabled.
Closes #60587