ILM: add force-merge step to searchable snapshots action#60819
Merged
andreidan merged 8 commits intoelastic:masterfrom Aug 10, 2020
Merged
ILM: add force-merge step to searchable snapshots action#60819andreidan merged 8 commits intoelastic:masterfrom
andreidan merged 8 commits intoelastic:masterfrom
Conversation
This adds a force-merge step to the searchable snapshot action, enabled by default,
but parameterizable using the `force_merge-index" optional boolean.
eg.
```
PUT _ilm/policy/my_policy
{
"policy": {
"phases": {
"cold": {
"actions": {
"searchable_snapshot" : {
"snapshot_repository" : "backing_repo",
"force_merge_index": true
}
}
}
}
}
}
```
Collaborator
|
Pinging @elastic/es-core-features (:Core/Features/ILM+SLM) |
dakrone
approved these changes
Aug 6, 2020
Member
dakrone
left a comment
There was a problem hiding this comment.
LGTM, left a couple really minor things, thanks Andrei!
| Force merges the managed index to one segment. | ||
| Defaults to `true`. | ||
| If the managed index was already force merged using the | ||
| <<ilm-forcemerge, force merge action>> in the `cold` or `warm` phase |
Member
There was a problem hiding this comment.
Super minor, but we allow force merge in "hot", so maybe we should just say
If the managed index was already force merged using the
<<ilm-forcemerge, force merge action>> in a previous action
the `searchable snapshot` action force merge step will be a no-op.
Member
There was a problem hiding this comment.
We might also want to mention that force merging is best effort, since it's possible for it to fail (and we still continue)
x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/ilm/SearchableSnapshotAction.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Lee Hinman <dakrone@users.noreply.github.com>
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Aug 10, 2020
This adds a force-merge step to the searchable snapshot action, enabled by default,
but parameterizable using the `force_merge-index" optional boolean.
eg.
```
PUT _ilm/policy/my_policy
{
"policy": {
"phases": {
"cold": {
"actions": {
"searchable_snapshot" : {
"snapshot_repository" : "backing_repo",
"force_merge_index": true
}
}
}
}
}
}
```
(cherry picked from commit d0a17b2)
Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
that referenced
this pull request
Aug 10, 2020
… (#60882) This adds a force-merge step to the searchable snapshot action, enabled by default, but parameterizable using the `force_merge-index" optional boolean. eg. ``` PUT _ilm/policy/my_policy { "policy": { "phases": { "cold": { "actions": { "searchable_snapshot" : { "snapshot_repository" : "backing_repo", "force_merge_index": true } } } } } } ``` (cherry picked from commit d0a17b2) Signed-off-by: Andrei Dan <andrei.dan@elastic.co>
andreidan
added a commit
to andreidan/elasticsearch
that referenced
this pull request
Aug 10, 2020
This also adjusts the serialisation version checks
andreidan
added a commit
that referenced
this pull request
Aug 10, 2020
61 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a force-merge step to the searchable snapshot action, enabled by default,
but parameterizable using the `force_merge-index" optional boolean.
eg.
Relates to #53488
Closes #56215