Skip to content

[ML] have DELETE analytics ignore stats failures and clean up unused stats#60776

Merged
benwtrent merged 2 commits intoelastic:masterfrom
benwtrent:feature/ml-analytics-delete-ignore-stats
Aug 5, 2020
Merged

[ML] have DELETE analytics ignore stats failures and clean up unused stats#60776
benwtrent merged 2 commits intoelastic:masterfrom
benwtrent:feature/ml-analytics-delete-ignore-stats

Conversation

@benwtrent
Copy link
Copy Markdown
Member

When deleting an analytics configuration, the request MIGHT fail if
the .ml-stats index does not exist or is in strange state (shards unallocated).

Instead of making the request fail, we should log that we were unable to delete the stats docs and then
have them cleaned up in the 'delete_expire_data' janitorial process.

closes #60462

@benwtrent benwtrent added >test Issues or PRs that are addressing/adding tests :ml Machine learning v8.0.0 v7.10.0 labels Aug 5, 2020
@elasticmachine
Copy link
Copy Markdown
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent
Copy link
Copy Markdown
Member Author

@elasticmachine update branch

Copy link
Copy Markdown

@droberts195 droberts195 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benwtrent benwtrent merged commit 02b9f77 into elastic:master Aug 5, 2020
@benwtrent benwtrent deleted the feature/ml-analytics-delete-ignore-stats branch August 5, 2020 18:56
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Aug 5, 2020
…stats (elastic#60776)

When deleting an analytics configuration, the request MIGHT fail if
the .ml-stats index does not exist or is in strange state (shards unallocated).

Instead of making the request fail, we should log that we were unable to delete the stats docs and then
have them cleaned up in the 'delete_expire_data' janitorial process.
benwtrent added a commit that referenced this pull request Aug 6, 2020
…nused stats (#60776) (#60784)

* [ML] have DELETE analytics ignore stats failures and clean up unused stats (#60776)

When deleting an analytics configuration, the request MIGHT fail if
the .ml-stats index does not exist or is in strange state (shards unallocated).

Instead of making the request fail, we should log that we were unable to delete the stats docs and then
have them cleaned up in the 'delete_expire_data' janitorial process
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

:ml Machine learning >test Issues or PRs that are addressing/adding tests v7.10.0 v8.0.0-alpha1

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[CI] Deleting data frame analytics jobs can throw all shards failed

4 participants